Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50713

Timestamper URL paths are incorrect in README examples

    Details

    • Similar Issues:

      Description

      In the wiki, you describe the timestamp paths as the following:

       

      Examples:
      
      /timestamps
      By default, display the elapsed time in seconds with three places after the decimal point.
      /timestamps?time=HH:mm:ss&appendLog
      Display the system clock time and append the line from the log.
      /timestamps?elapsed=HH:mm:ss.S&appendLog
      Display the elapsed time and append the line from the log.
      /timestamps?time=HH:mm:ss&elapsed=HH:mm:ss.S
      Display both the system clock time and the elapsed time.
      /timestamps?currentTime&time=HH:mm:ss
      Display the current time on the Jenkins master.

       

      These paths are incorrect. When sending a request to /timestamps?time=HH:mm:ss&appendLog for example:

       

      < HTTP/1.1 302 Found
      < Server: nginx/1.10.2
      < Date: Tue, 10 Apr 2018 10:31:27 GMT
      < Transfer-Encoding: chunked
      < Connection: keep-alive
      < X-Content-Type-Options: nosniff
      < Access-Control-Allow-Origin: *
      < Access-Control-Allow-Methods: GET, POST, PUT, DELETE
      < Access-Control-Allow-Headers: Authorization
      < Set-Cookie: JSESSIONID.10fc358a=node012rg8l3t0wed1579tpofuy89u1019.node0;Path=/;Secure;HttpOnly
      < Expires: Thu, 01 Jan 1970 00:00:00 GMT
      

       

       

      The correct paths are with trailing '/': /timestamps/?time=HH:mm:ss&appendLog

      Can we fix this issue, or fix the readme?

        Attachments

          Activity

          Hide
          stevengbrown Steven G Brown added a comment -

          Thank you for reporting this Roy Arnon! Would you be willing to update the wiki?

          Show
          stevengbrown Steven G Brown added a comment - Thank you for reporting this Roy Arnon ! Would you be willing to update the wiki?
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Steven Brown
          Path:
          src/main/java/hudson/plugins/timestamper/format/ElapsedTimestampFormat.java
          src/main/java/hudson/plugins/timestamper/format/SystemTimestampFormat.java
          src/test/java/hudson/plugins/timestamper/format/ElapsedTimestampFormatTest.java
          src/test/java/hudson/plugins/timestamper/format/SystemTimestampFormatTest.java
          http://jenkins-ci.org/commit/timestamper-plugin/53c91f964ed5be26aa0880c5e1893720da65df17
          Log:
          JENKINS-50713 Add forward slash to timestamps URLs

          This seems to be the correct URL and without the forward slash some web
          servers (e.g. nginx) fail to load the page.

          The Jenkins built-in web server was not affected because it redirects to
          add the forward slash automatically.

          *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

          Functionality will be removed from GitHub.com on January 31st, 2019.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Steven Brown Path: src/main/java/hudson/plugins/timestamper/format/ElapsedTimestampFormat.java src/main/java/hudson/plugins/timestamper/format/SystemTimestampFormat.java src/test/java/hudson/plugins/timestamper/format/ElapsedTimestampFormatTest.java src/test/java/hudson/plugins/timestamper/format/SystemTimestampFormatTest.java http://jenkins-ci.org/commit/timestamper-plugin/53c91f964ed5be26aa0880c5e1893720da65df17 Log: JENKINS-50713 Add forward slash to timestamps URLs This seems to be the correct URL and without the forward slash some web servers (e.g. nginx) fail to load the page. The Jenkins built-in web server was not affected because it redirects to add the forward slash automatically. * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
          Hide
          stevengbrown Steven G Brown added a comment -

          I've updated the wiki and also the URLs used within the plugin. Will be included in the next release.

          Show
          stevengbrown Steven G Brown added a comment - I've updated the wiki and also the URLs used within the plugin. Will be included in the next release.
          Hide
          stevengbrown Steven G Brown added a comment -

          Fixed included in Timestamper 1.8.10 which will be available shortly.

          Show
          stevengbrown Steven G Brown added a comment - Fixed included in Timestamper 1.8.10 which will be available shortly.

            People

            • Assignee:
              stevengbrown Steven G Brown
              Reporter:
              hellspam Roy Arnon
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: