Details

    • Similar Issues:
    • Released As:
      1.8

      Description

      It seems that when you upload even a file named something.txt, it gets an octet-stream content type on S3, so even if you click the view link in Classic UI on the artifacts page, your browser gets a downloaded file rather than displaying inline. Must be some way to tell jClouds/S3 to sniff content type automatically. OTOH there may be some dangerous types which we would want to serve only as plain text or binary.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            No Oleg Nenashev that was just an API.

            Show
            jglick Jesse Glick added a comment - No Oleg Nenashev that was just an API.
            Show
            oleg_nenashev Oleg Nenashev added a comment - Released in  https://github.com/jenkinsci/apache-httpcomponents-client-4-api-plugin/releases/tag/apache-httpcomponents-client-4-api-4.5.10-2.0
            Hide
            jglick Jesse Glick added a comment -

            Thanks! I will try to review soon.

            Show
            jglick Jesse Glick added a comment - Thanks! I will try to review soon.
            Hide
            rverduijn Robin Verduijn added a comment -

            I took a stab at this, and was able to get a custom-built version of the plugin working for me locally: it uploads files to S3 with content-type set appropriately which makes them properly viewable in the browser (for inline file types such as text/plain and text/html) instead of always forcing them to be downloaded.

             

            This took changes to both the artifact-manager-s3 and apache-httpcomponents-client-4-api-plugin repositories, since I had to ensure when the plugin performs an HTTP upload it also specifies the "Content-Type" header and I used a new method signature in RobustHTTPClient to do so.

             

            My changes can be viewed at:

             

             

            While, as I said, a custom plugin that has these changes appears to do the right thing for me and I also added several tests to verify uploads to (and subsequent downloads from) S3 are setting the content-type now, this is my first contribution to the project so I might well have missed something. Any suggestions or feedback welcome... I hope it at least provides a starting point for a fix to this issue, if nothing else.

            Show
            rverduijn Robin Verduijn added a comment - I took a stab at this, and was able to get a custom-built version of the plugin working for me locally: it uploads files to S3 with content-type set appropriately which makes them properly viewable in the browser (for inline file types such as text/plain and text/html) instead of always forcing them to be downloaded.   This took changes to both the artifact-manager-s3 and apache-httpcomponents-client-4-api-plugin repositories, since I had to ensure when the plugin performs an HTTP upload it also specifies the "Content-Type" header and I used a new method signature in RobustHTTPClient to do so.   My changes can be viewed at:   https://github.com/jenkinsci/apache-httpcomponents-client-4-api-plugin/pull/24 https://github.com/jenkinsci/artifact-manager-s3-plugin/pull/100   While, as I said, a custom plugin that has these changes appears to do the right thing for me and I also added several tests to verify uploads to (and subsequent downloads from) S3 are setting the content-type now, this is my first contribution to the project so I might well have missed something. Any suggestions or feedback welcome... I hope it at least provides a starting point for a fix to this issue, if nothing else.
            Hide
            nanonyme Seppo Yli-Olli added a comment - - edited

            Even if you only populated content type for most common things (txt, html), this would still be useful. Is this being actively worked on? This limitation makes using HTML reports through Jenkins web UI quite painful if this plugin is active. My assumption based on what I've seen thus far is latter option is the right one but it could be that I'm just missing some details of presigned URL's.

            Show
            nanonyme Seppo Yli-Olli added a comment - - edited Even if you only populated content type for most common things (txt, html), this would still be useful. Is this being actively worked on? This limitation makes using HTML reports through Jenkins web UI quite painful if this plugin is active. My assumption based on what I've seen thus far is latter option is the right one but it could be that I'm just missing some details of presigned URL's.

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                6 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: