Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5087

IRC plugin should either not use NOTICE or should be configurable to use normal messages

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The current IRC bot sends all its messages to channels using NOTIFY, which on many clients shows up as a global message (or worse, as a pop-up messsage). If this is desirable, it should at least be possible to configure the bot to use normal IRC messages to the channels, so that people won't see the messages across all terminals/windows or worse.

        Attachments

          Activity

          headius headius created issue -
          Hide
          kutzi kutzi added a comment -

          Do you mean NOTICE? I don't see any place where the bot uses notify.

          AFAI understand IRC /notice should be used to prevent automatic replies from other bots - which is exactly what we want - and otherwise shouldn't be any different from /msg. So I don't see why /msg should be better.

          http://www.livinginternet.com/r/ra_priv.htm

          Show
          kutzi kutzi added a comment - Do you mean NOTICE? I don't see any place where the bot uses notify. AFAI understand IRC /notice should be used to prevent automatic replies from other bots - which is exactly what we want - and otherwise shouldn't be any different from /msg. So I don't see why /msg should be better. http://www.livinginternet.com/r/ra_priv.htm
          Hide
          headius headius added a comment -

          Yes, sorry, I meant NOTICE.

          I understand the reason you explain for using NOTICE, but whenever we have our bot display help or results or anything, we get complaints from people in lots of different channels, since NOTICE often shows up very loudly and across windows or channels. At any rate, I don't think make it configurable would harm anyone, and the default could still be NOTICE if you like.

          FWIW, no other IRC bots I've ever used use NOTICE for interaction. They all message the channel or user directly.

          Show
          headius headius added a comment - Yes, sorry, I meant NOTICE. I understand the reason you explain for using NOTICE, but whenever we have our bot display help or results or anything, we get complaints from people in lots of different channels, since NOTICE often shows up very loudly and across windows or channels. At any rate, I don't think make it configurable would harm anyone, and the default could still be NOTICE if you like. FWIW, no other IRC bots I've ever used use NOTICE for interaction. They all message the channel or user directly.
          kutzi kutzi made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : kutzi
          Path:
          trunk/hudson/plugins/ircbot/pom.xml
          trunk/hudson/plugins/ircbot/src/main/java/hudson/plugins/ircbot/IrcPublisher.java
          trunk/hudson/plugins/ircbot/src/main/java/hudson/plugins/ircbot/v2/IRCConnection.java
          trunk/hudson/plugins/ircbot/src/main/java/hudson/plugins/ircbot/v2/PircConnection.java
          trunk/hudson/plugins/ircbot/src/main/resources/hudson/plugins/ircbot/IrcPublisher/config.jelly
          trunk/hudson/plugins/ircbot/src/main/resources/hudson/plugins/ircbot/IrcPublisher/global.jelly
          http://fisheye4.cenqua.com/changelog/hudson/?cs=24639
          Log:

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : kutzi Path: trunk/hudson/plugins/ircbot/pom.xml trunk/hudson/plugins/ircbot/src/main/java/hudson/plugins/ircbot/IrcPublisher.java trunk/hudson/plugins/ircbot/src/main/java/hudson/plugins/ircbot/v2/IRCConnection.java trunk/hudson/plugins/ircbot/src/main/java/hudson/plugins/ircbot/v2/PircConnection.java trunk/hudson/plugins/ircbot/src/main/resources/hudson/plugins/ircbot/IrcPublisher/config.jelly trunk/hudson/plugins/ircbot/src/main/resources/hudson/plugins/ircbot/IrcPublisher/global.jelly http://fisheye4.cenqua.com/changelog/hudson/?cs=24639 Log: JENKINS-4629 notify upstream committers JENKINS-5087 use /msg instead of /notice (configurable)
          Hide
          kutzi kutzi added a comment -

          edited summary

          Show
          kutzi kutzi added a comment - edited summary
          kutzi kutzi made changes -
          Summary IRC plugin should either not use NOTIFY or should be configurable to use normal messages IRC plugin should either not use NOTICE or should be configurable to use normal messages
          Hide
          kutzi kutzi added a comment -

          Fixed in version 2.1

          Default is now to use /msg.
          A global option allows to revert to old behaviour (/notice)

          Show
          kutzi kutzi added a comment - Fixed in version 2.1 Default is now to use /msg. A global option allows to revert to old behaviour (/notice)
          kutzi kutzi made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          abayer Andrew Bayer made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 135171 ] JNJira + In-Review [ 203311 ]

            People

            • Assignee:
              kutzi kutzi
              Reporter:
              headius headius
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: