Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5119

Winstone: Memory leak due to default session timeout of -1

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Environment:
      Hudson 1.337 (Winstone), Solaris 10 SPARC, Sun JDK 1.6.0_16
    • Similar Issues:

      Description

      We are running Hudson with its embedded Winstone servlet engine. User authentication within Hudson is done via Hudsons LDAP security realm using our corporate ActiveDirectory via LDAP.

      After running Hudson a few weeks we're running into OutOfMemory exceptions. Here the culprit is a single winstone.WebAppConfiguration instance holding a lot of winstone.WinStoneSession instances each holding an Acegi RememberMeAuthenticationToken instance with 36k data from the authenticated users AD record.

      It seems that Hudson isn't setting Winstones session timeout. Without specifying a session timeout winstone.WebAppConfiguration.makeNewSession() is using a session timeout of -1.

        Attachments

          Issue Links

            Activity

            Hide
            kohsuke Kohsuke Kawaguchi added a comment -

            Fixed in Winstone 0.9.10-hudson-17 to have the finite default session timeout value. This change still needs to be integrated into Hudson.

            Show
            kohsuke Kohsuke Kawaguchi added a comment - Fixed in Winstone 0.9.10-hudson-17 to have the finite default session timeout value. This change still needs to be integrated into Hudson.
            Hide
            amrangan amrangan added a comment -

            Will this change be integrated into the next release of Hudson (i.e. 1.356) ?

            Show
            amrangan amrangan added a comment - Will this change be integrated into the next release of Hudson (i.e. 1.356) ?
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : kohsuke
            Path:
            trunk/hudson/main/war/pom.xml
            trunk/www/changelog.html
            http://jenkins-ci.org/commit/30797
            Log:
            [FIXED JENKINS-5119] integrated a newer version of Winstone with memory leak fix and SSL certificate handling improvement.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/hudson/main/war/pom.xml trunk/www/changelog.html http://jenkins-ci.org/commit/30797 Log: [FIXED JENKINS-5119] integrated a newer version of Winstone with memory leak fix and SSL certificate handling improvement.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : kohsuke
            Path:
            trunk/hudson/main/war/pom.xml
            trunk/www/changelog.html
            http://jenkins-ci.org/commit/33533
            Log:
            [FIXED JENKINS-5119] integrated another Winstone that fixes session object leak.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/hudson/main/war/pom.xml trunk/www/changelog.html http://jenkins-ci.org/commit/33533 Log: [FIXED JENKINS-5119] integrated another Winstone that fixes session object leak.
            Hide
            dogfood dogfood added a comment -

            Integrated in hudson_main_trunk #154
            [FIXED JENKINS-5119] integrated another Winstone that fixes session object leak.

            kohsuke :
            Files :

            • /trunk/hudson/main/war/pom.xml
            • /trunk/www/changelog.html
            Show
            dogfood dogfood added a comment - Integrated in hudson_main_trunk #154 [FIXED JENKINS-5119] integrated another Winstone that fixes session object leak. kohsuke : Files : /trunk/hudson/main/war/pom.xml /trunk/www/changelog.html

              People

              • Assignee:
                Unassigned
                Reporter:
                tjuerge tjuerge
              • Votes:
                5 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: