Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51283

CASC_JENKINS_CONFIG environment variable is not used anymore

    Details

    • Sprint:
      Evergreen - Milestone 1
    • Similar Issues:

      Description

      Seems like a recent commit broke the usage of the CASC_JENKINS_CONFIG environment variable to point to the CasC configuration file.

      I found it out by updating to latest master of CasC in evergreen. It will be blocking us as long as we use latest tip of master.

      I bisected the issue:

      $ git bisect log
      git bisect start 
      # good: [987b55ffdf7e7468ac9b739e5d7bee6129cfa7fc] [maven-release-plugin] prepare release configuration-as-code-0.4-a
      lpha 
      git bisect good 987b55ffdf7e7468ac9b739e5d7bee6129cfa7fc 
      # bad: [882d85351b045a33de7b91cf9cc5137d940a3626] Fix compilation error 
      git bisect bad 882d85351b045a33de7b91cf9cc5137d940a3626 
      # good: [8921814751e0465ba31b853b9adec18bb557f0ff] [maven-release-plugin] prepare release configuration-as-code-0.5-a
      lpha 
      git bisect good 8921814751e0465ba31b853b9adec18bb557f0ff 
      # good: [4995ef13dc106f77bb121bcbaf25bd32157f68e3] integrations are not root elements 
      git bisect good 4995ef13dc106f77bb121bcbaf25bd32157f68e3 
      # skip: [bdf0f0f47fea6d7641fc9741113ac4293409fee7] merge yaml trees before applying configuration #184 
      git bisect skip bdf0f0f47fea6d7641fc9741113ac4293409fee7 
      # skip: [18f91bdca9f96c72300f57e459c183796725251e] use the same merge sample as reported in issue 
      git bisect skip 18f91bdca9f96c72300f57e459c183796725251e 
      # good: [2b45fd6392aba3f80eb805b437073064bc9cb1b7] improve attribute type safety and get/set while writing custom con
      figurators 
      git bisect good 2b45fd6392aba3f80eb805b437073064bc9cb1b7 
      # only skipped commits left to test 
      # possible first bad commit: [882d85351b045a33de7b91cf9cc5137d940a3626] Fix compilation error 
      # possible first bad commit: [18f91bdca9f96c72300f57e459c183796725251e] use the same merge sample as reported in issu
      e 
      # possible first bad commit: [bdf0f0f47fea6d7641fc9741113ac4293409fee7] merge yaml trees before applying configuratio
      n #184
      

      cc Nicolas De Loof I think.

        Attachments

          Activity

          Show
          ndeloof Nicolas De Loof added a comment - please use https://github.com/jenkinsci/configuration-as-code-plugin/issues  for CasC
          Hide
          batmat Baptiste Mathus added a comment -

          OK, TBH I strongly disagree with using GH issues. It might make things slighly easier for CasC isolatedly, but makes it much harder to link issues together on a central places, which is very useful IMO.

          Show
          batmat Baptiste Mathus added a comment - OK, TBH I strongly disagree with using GH issues. It might make things slighly easier for CasC isolatedly, but makes it much harder to link issues together on a central places, which is very useful IMO.
          Show
          batmat Baptiste Mathus added a comment - Re-filed as https://github.com/jenkinsci/configuration-as-code-plugin/issues/203
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          src/main/java/org/jenkinsci/plugins/casc/ConfigurationAsCode.java
          src/test/java/org/jenkinsci/plugins/casc/JenkinsConfigTest.java
          src/test/resources/org/jenkinsci/plugins/casc/JenkinsConfigTest.yml
          http://jenkins-ci.org/commit/configuration-as-code-plugin/8ab67e7776ac5d7c0b3ca0ff8245cdfe10075ebe
          Log:
          fix broken CASC_JENKINS_CONFIG_ENV support + test case
          [FIX JENKINS-51283] close #203

          *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

          Functionality will be removed from GitHub.com on January 31st, 2019.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: src/main/java/org/jenkinsci/plugins/casc/ConfigurationAsCode.java src/test/java/org/jenkinsci/plugins/casc/JenkinsConfigTest.java src/test/resources/org/jenkinsci/plugins/casc/JenkinsConfigTest.yml http://jenkins-ci.org/commit/configuration-as-code-plugin/8ab67e7776ac5d7c0b3ca0ff8245cdfe10075ebe Log: fix broken CASC_JENKINS_CONFIG_ENV support + test case [FIX JENKINS-51283] close #203 * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          src/main/java/org/jenkinsci/plugins/casc/ConfigurationAsCode.java
          src/test/java/org/jenkinsci/plugins/casc/JenkinsConfigTest.java
          src/test/resources/org/jenkinsci/plugins/casc/JenkinsConfigTest.yml
          http://jenkins-ci.org/commit/configuration-as-code-plugin/a427774ea7ca52ae312b650a48b190fe2e3ad73e
          Log:
          fix broken CASC_JENKINS_CONFIG_ENV support + test case
          [FIX JENKINS-51283] close #203

          Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

          *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

          Functionality will be removed from GitHub.com on January 31st, 2019.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: src/main/java/org/jenkinsci/plugins/casc/ConfigurationAsCode.java src/test/java/org/jenkinsci/plugins/casc/JenkinsConfigTest.java src/test/resources/org/jenkinsci/plugins/casc/JenkinsConfigTest.yml http://jenkins-ci.org/commit/configuration-as-code-plugin/a427774ea7ca52ae312b650a48b190fe2e3ad73e Log: fix broken CASC_JENKINS_CONFIG_ENV support + test case [FIX JENKINS-51283] close #203 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

            People

            • Assignee:
              ewel Ewelina Wilkosz
              Reporter:
              batmat Baptiste Mathus
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: