Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51395

withDockerRegistry([...]) syntax no longer accepted

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Andrew Bayer's JENKINS-29711 allowed a parameter name to be omitted where there was a single parameter taking a nested structure and there were no other parameters. withDockerRegistry took advantage of this to allow the registry: to be elided. After JENKINS-38018 introduced an (optional) toolName parameter, this syntax stopped working; DSL silently omitted the registry parameter—and silently ignored the url and/or credentialsId parameters! Worse, Snippetizer offers the broken syntax when toolName is unset.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/test/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStepTest.java
            http://jenkins-ci.org/commit/docker-workflow-plugin/732e1bbf514a65893ebb381850884385e69b9ae1
            Log:
            JENKINS-51395 At least reproduced problem in test.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/test/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStepTest.java http://jenkins-ci.org/commit/docker-workflow-plugin/732e1bbf514a65893ebb381850884385e69b9ae1 Log: JENKINS-51395 At least reproduced problem in test.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStep.java
            src/main/resources/org/jenkinsci/plugins/docker/workflow/Docker.groovy
            src/test/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStepTest.java
            http://jenkins-ci.org/commit/docker-workflow-plugin/8c463ba72f69c0c0e1fca60c11fb5e88e3dbe0e4
            Log:
            JENKINS-51395 Switching recommended syntax to inline arguments, while still supporting the old syntax.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStep.java src/main/resources/org/jenkinsci/plugins/docker/workflow/Docker.groovy src/test/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStepTest.java http://jenkins-ci.org/commit/docker-workflow-plugin/8c463ba72f69c0c0e1fca60c11fb5e88e3dbe0e4 Log: JENKINS-51395 Switching recommended syntax to inline arguments, while still supporting the old syntax.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStep.java
            src/main/java/org/jenkinsci/plugins/docker/workflow/ServerEndpointStep.java
            src/main/resources/org/jenkinsci/plugins/docker/workflow/Docker.groovy
            src/test/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStepTest.java
            http://jenkins-ci.org/commit/docker-workflow-plugin/e8a1815cf41ba67a72ad7ce4384763f36143c4d1
            Log:
            Merge pull request #138 from jglick/withDockerRegistry-syntax-JENKINS-51395

            JENKINS-51395 Syntax problems in withDockerRegistry

            Compare: https://github.com/jenkinsci/docker-workflow-plugin/compare/c5a73943a283...e8a1815cf41b
            *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

            Functionality will be removed from GitHub.com on January 31st, 2019.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStep.java src/main/java/org/jenkinsci/plugins/docker/workflow/ServerEndpointStep.java src/main/resources/org/jenkinsci/plugins/docker/workflow/Docker.groovy src/test/java/org/jenkinsci/plugins/docker/workflow/RegistryEndpointStepTest.java http://jenkins-ci.org/commit/docker-workflow-plugin/e8a1815cf41ba67a72ad7ce4384763f36143c4d1 Log: Merge pull request #138 from jglick/withDockerRegistry-syntax- JENKINS-51395 JENKINS-51395 Syntax problems in withDockerRegistry Compare: https://github.com/jenkinsci/docker-workflow-plugin/compare/c5a73943a283...e8a1815cf41b * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
            Hide
            jglick Jesse Glick added a comment -
            Show
            jglick Jesse Glick added a comment - Fix available for download
            Hide
            allan_burdajewicz Allan BURDAJEWICZ added a comment -

            The patch works. Thanks!

            Show
            allan_burdajewicz Allan BURDAJEWICZ added a comment - The patch works. Thanks!

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: