Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51418

Automatic signing broken with version 2.0.2 and xcode 9

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Blocker
    • Resolution: Fixed
    • Component/s: xcode-plugin
    • Labels:
    • Environment:
      xcode-plugin 2.0.2
      jenkins 2.107.3
    • Similar Issues:

      Description

      The changes for fixing Bug JENKINS-47744JENKINS-45509

      With

      PR #86, PR#87

      Automatic signing is broken with xcode 9. Because with those changes the development team isn't given to the xcode commandline in automatic signing mode.

      The development team must be always given to the xcode commandline regardless if automatic signing is used or not!

      In Manual signing mode only an provisioning profile must be provided additional to the teamid.

      The selection of the development team should be restored to the old behaviour.

       
      E.g. the code in XCodeBuilder.java should be changed from

       

      // handle code signing identities
      if (manualSigning != null && manualSigning && !StringUtils.isEmpty(developmentTeamID)) {
          commandLine.add("DEVELOPMENT_TEAM=" + developmentTeamID);
          xcodeReport.append(", developmentTeamID: ").append(developmentTeamID);
      } else {
          commandLine.add("-allowProvisioningUpdates");
          xcodeReport.append(", developmentTeamID: AUTOMATIC");
      }
      

      to something like this (untestet)

       

      // handle code signing identities
      if (!StringUtils.isEmpty(developmentTeamID)) {
          commandLine.add("DEVELOPMENT_TEAM=" + developmentTeamID);
          xcodeReport.append(", developmentTeamID: ").append(developmentTeamID);
      } else {
          xcodeReport.append(", developmentTeamID: DEFAULT");
      }
      
      // Handle provisioning profile
      if (manualSigning == null || !manualSigning) {
          commandLine.add("-allowProvisioningUpdates");
      }
      

       The  "-allowProvisioningUpdates" option exists only in xcode >= 9 This will break usage of the plugin with xcode < 9

        Attachments

          Activity

          stephanwezelps Stephan Wezel created issue -
          stephanwezelps Stephan Wezel made changes -
          Field Original Value New Value
          Description The changes for fixing Bug JENKINS-47744JENKINS-45509

          With

          [PR #86|https://github.com/jenkinsci/xcode-plugin/pull/86], [PR#87|https://github.com/jenkinsci/xcode-plugin/pull/87]

          Automatic signing is broken with xcode 9. Because with those changes the development team isn't given to the xcode commandline in automatic signing mode.

          The development team must be always given to the xcode commandline regardless if automatic signing is used or not!

          In Manual signing mode only an provisioning profile must be provided additional to the teamid.

          The selection of the development team should be restored to the old behaviour.

           
           E.g. the code in XCodeBuilder.java should be changed from

           
          {code:java}
          // handle code signing identities
          if (manualSigning != null && manualSigning && !StringUtils.isEmpty(developmentTeamID)) {
              commandLine.add("DEVELOPMENT_TEAM=" + developmentTeamID);
              xcodeReport.append(", developmentTeamID: ").append(developmentTeamID);
          } else {
              commandLine.add("-allowProvisioningUpdates");
              xcodeReport.append(", developmentTeamID: AUTOMATIC");
          }
          {code}
          to something like this (untestet)

           
          {code:java}
          // handle code signing identities
          if (!StringUtils.isEmpty(developmentTeamID)) {
              commandLine.add("DEVELOPMENT_TEAM=" + developmentTeamID);
              xcodeReport.append(", developmentTeamID: ").append(developmentTeamID);
          } else {
              xcodeReport.append(", developmentTeamID: DEFAULT");
          }

          // Handle provisioning profile
          if (manualSigning == null || !manualSigning) {
              commandLine.add("-allowProvisioningUpdates");
          }
          {code}
           
          The changes for fixing Bug JENKINS-47744JENKINS-45509

          With

          [PR #86|https://github.com/jenkinsci/xcode-plugin/pull/86], [PR#87|https://github.com/jenkinsci/xcode-plugin/pull/87]

          Automatic signing is broken with xcode 9. Because with those changes the development team isn't given to the xcode commandline in automatic signing mode.

          The development team must be always given to the xcode commandline regardless if automatic signing is used or not!

          In Manual signing mode only an provisioning profile must be provided additional to the teamid.

          The selection of the development team should be restored to the old behaviour.

           
           E.g. the code in XCodeBuilder.java should be changed from

           
          {code:java}
          // handle code signing identities
          if (manualSigning != null && manualSigning && !StringUtils.isEmpty(developmentTeamID)) {
              commandLine.add("DEVELOPMENT_TEAM=" + developmentTeamID);
              xcodeReport.append(", developmentTeamID: ").append(developmentTeamID);
          } else {
              commandLine.add("-allowProvisioningUpdates");
              xcodeReport.append(", developmentTeamID: AUTOMATIC");
          }
          {code}
          to something like this (untestet)

           
          {code:java}
          // handle code signing identities
          if (!StringUtils.isEmpty(developmentTeamID)) {
              commandLine.add("DEVELOPMENT_TEAM=" + developmentTeamID);
              xcodeReport.append(", developmentTeamID: ").append(developmentTeamID);
          } else {
              xcodeReport.append(", developmentTeamID: DEFAULT");
          }

          // Handle provisioning profile
          if (manualSigning == null || !manualSigning) {
              commandLine.add("-allowProvisioningUpdates");
          }
          {code}
           The  "-allowProvisioningUpdates" option exists only in xcode >= 9 This will break usage of the plugin with xcode < 9
          kazuhidet Kazuhide Takahashi made changes -
          Assignee Kazuhide Takahashi [ kazuhidet ]
          kazuhidet Kazuhide Takahashi made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          kazuhidet Kazuhide Takahashi made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          kazuhidet Kazuhide Takahashi made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              kazuhidet Kazuhide Takahashi
              Reporter:
              stephanwezelps Stephan Wezel
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: