Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51495

descriptorRadioList does not honor DescriptorVisibilityFilter

    Details

    • Similar Issues:
    • Released As:
      Jenkins 2.224 (reverted in 2.225)

      Description

      descriptorRadioList does not honor DescriptorVisibilityFilter extensions.

      The workaround for this has been to pass an already filtered list of descriptors to descriptorRadioList (ie here):

      f.descriptorRadioList([...], descriptors: h.filterDescriptors(app, MyExtensionPoint.all()))
      

      However this has a side effect as descriptorRadioList is using an index to match frontend selected descriptor with a backend instance, so when a descriptor is hidden (by the visibility filter) in the frontend then backend indexes do not match.

      So, I believe descriptorRadioList should be fixed to either a) Generate correct indexes when there a visibility filter or b) stop using indexes to match things (which seems quite awkward).

        Attachments

          Issue Links

            Activity

            Hide
            matsushou Sho Matsumoto added a comment -

            > So, I believe descriptorRadioList should be fixed to either a) Generate correct indexes when there a visibility filter or b) stop using indexes to match things (which seems quite awkward).

            I followed b) plan and stop using indexes and begin using id instead.

            Show
            matsushou Sho Matsumoto added a comment - > So, I believe  descriptorRadioList  should be fixed to either a) Generate correct indexes when there a visibility filter or b) stop using indexes to match things (which seems quite awkward). I followed b) plan and stop using indexes and begin using id instead.
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            I am not sure it should be ported to LTS, definitely not to 2.222.1 taking the merge date

            Show
            oleg_nenashev Oleg Nenashev added a comment - I am not sure it should be ported to LTS, definitely not to 2.222.1 taking the merge date
            Show
            timja Tim Jacomb added a comment - This seems to have caused: https://issues.jenkins-ci.org/browse/JENKINS-61398?focusedCommentId=386921&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-386921
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            We rolled back the fix in 2.225 to fix the regression.

            https://github.com/jenkinsci/jenkins/pull/4562 was created for a new implementation

            Show
            oleg_nenashev Oleg Nenashev added a comment - We rolled back the fix in 2.225 to fix the regression. https://github.com/jenkinsci/jenkins/pull/4562  was created for a new implementation
            Hide
            olivergondza Oliver Gondža added a comment -

            I am reopening the issue to reflect that

            Show
            olivergondza Oliver Gondža added a comment - I am reopening the issue to reflect that

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                amuniz Antonio Muñiz
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated: