Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51495

descriptorRadioList does not honor DescriptorVisibilityFilter

    Details

    • Similar Issues:

      Description

      descriptorRadioList does not honor DescriptorVisibilityFilter extensions.

      The workaround for this has been to pass an already filtered list of descriptors to descriptorRadioList (ie here):

      f.descriptorRadioList([...], descriptors: h.filterDescriptors(app, MyExtensionPoint.all()))
      

      However this has a side effect as descriptorRadioList is using an index to match frontend selected descriptor with a backend instance, so when a descriptor is hidden (by the visibility filter) in the frontend then backend indexes do not match.

      So, I believe descriptorRadioList should be fixed to either a) Generate correct indexes when there a visibility filter or b) stop using indexes to match things (which seems quite awkward).

        Attachments

          Issue Links

            Activity

            Hide
            matsushou Sho Matsumoto added a comment -

            > So, I believe descriptorRadioList should be fixed to either a) Generate correct indexes when there a visibility filter or b) stop using indexes to match things (which seems quite awkward).

            I followed b) plan and stop using indexes and begin using id instead.

            Show
            matsushou Sho Matsumoto added a comment - > So, I believe  descriptorRadioList  should be fixed to either a) Generate correct indexes when there a visibility filter or b) stop using indexes to match things (which seems quite awkward). I followed b) plan and stop using indexes and begin using id instead.

              People

              • Assignee:
                matsushou Sho Matsumoto
                Reporter:
                amuniz Antonio Muñiz
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: