Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51603

workDirSettings in JNLPLauncher requirements are too strict, CasC plugin is impacted

    Details

    • Similar Issues:
    • Released As:
      Jenkins 2.126

      Description

      See https://github.com/jenkinsci/configuration-as-code-plugin/issues/233

      Currently the CasC plugin does not offer compatibility for old-style logic using @DataBoundConstructor. If a plugin configuration gets updated (new constructor, old is deprecated), the plugin just fails if newly introduced fields are non-null.

        Attachments

          Activity

          Hide
          jglick Jesse Glick added a comment -

          Merged, so fixed, yes?

          Show
          jglick Jesse Glick added a comment - Merged, so fixed, yes?
          Hide
          jglick Jesse Glick added a comment -

          …though I disagree with the fix.

          Show
          jglick Jesse Glick added a comment - …though I disagree with the fix.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/slaves/JNLPLauncher.java
          test/src/test/java/hudson/slaves/JNLPLauncherTest.java
          http://jenkins-ci.org/commit/jenkins/98b37699152595f35fce7387be0ee1717596650d
          Log:
          JENKINS-51603 The proper way to make a parameter optional is to use @DataBoundSetter.

          *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

          Functionality will be removed from GitHub.com on January 31st, 2019.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/slaves/JNLPLauncher.java test/src/test/java/hudson/slaves/JNLPLauncherTest.java http://jenkins-ci.org/commit/jenkins/98b37699152595f35fce7387be0ee1717596650d Log: JENKINS-51603 The proper way to make a parameter optional is to use @DataBoundSetter. * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
          Hide
          olivergondza Oliver Gondža added a comment -

          Oleg Nenashev,Jesse Glick, I prefer to either backport both the patches or none. Given Jesse's amendment is not yet merged, I lean towards skipping this in 1.121.2.

          Show
          olivergondza Oliver Gondža added a comment - Oleg Nenashev , Jesse Glick , I prefer to either backport both the patches or none. Given Jesse's amendment is not yet merged, I lean towards skipping this in 1.121.2.
          Hide
          jglick Jesse Glick added a comment -

          My amendment is merged, but very recently. I agree that this does not need to be in 2.121.2.

          Show
          jglick Jesse Glick added a comment - My amendment is merged, but very recently. I agree that this does not need to be in 2.121.2.

            People

            • Assignee:
              oleg_nenashev Oleg Nenashev
              Reporter:
              oleg_nenashev Oleg Nenashev
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: