Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51660

Setup wizard suggests root URL not ending in slash

    Details

    • Similar Issues:

      Description

      The implementation of JENKINS-31661 suggests http://localhost:8080/jenkins as the root URL if you run with --prefix=/jenkins. It must be http://localhost:8080/jenkins/ in this case, or http://localhost:8080/ if the prefix is undefined (so, blank).

        Attachments

          Issue Links

            Activity

            jglick Jesse Glick created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue blocks JENKINS-31661 [ JENKINS-31661 ]
            Hide
            jglick Jesse Glick added a comment -

            I suppose for settings compatibility, we should append a slash to a saved root URL which is missing one, but the validator should require it going forward.

            Show
            jglick Jesse Glick added a comment - I suppose for settings compatibility, we should append a slash to a saved root URL which is missing one, but the validator should require it going forward.
            danielbeck Daniel Beck made changes -
            Labels lts-candidate
            wfollonier Wadeck Follonier made changes -
            Remote Link This issue links to "#3474 core (Web Link)" [ 20791 ]
            wfollonier Wadeck Follonier made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            wfollonier Wadeck Follonier added a comment -

            In the current version, the method that save the URL add the slash if it's missing and in addition, the read method ensure the slash is present.

            I just changed the JavaScript URL guessing method to let the trailing slash.

            Show
            wfollonier Wadeck Follonier added a comment - In the current version, the method that save the URL add the slash if it's missing and in addition, the read method ensure the slash is present. I just changed the JavaScript URL guessing method to let the trailing slash.
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Fixed in Jenkins 2.127

            Show
            oleg_nenashev Oleg Nenashev added a comment - Fixed in Jenkins 2.127
            oleg_nenashev Oleg Nenashev made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate 2.121.2-rejected lts-candidate
            Hide
            olivergondza Oliver Gondža added a comment -

            The way I understand this, this is to ensure the default is correct as soon as suggested by javascript so it does not have to be fixed on server side. This surely makes things better/easier though I doubt this is worth the backport presuming this does not correct any user-observable problem.

            Show
            olivergondza Oliver Gondža added a comment - The way I understand this, this is to ensure the default is correct as soon as suggested by javascript so it does not have to be fixed on server side. This surely makes things better/easier though I doubt this is worth the backport presuming this does not correct any user-observable problem.
            olivergondza Oliver Gondža made changes -
            Labels 2.121.2-rejected lts-candidate 2.121.2-rejected

              People

              • Assignee:
                wfollonier Wadeck Follonier
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: