Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-52014

Plugin POM Uses Single Version String Hardcoded To Only Work With Java 8 or earlier

    Details

    • Similar Issues:

      Description

      Previously Java versions strings were 1.x, so the plugin-pom hardcodes a java.level property of "8" like so:

      <source>1.${java.level}</source>

      See: https://github.com/jenkinsci/plugin-pom/blob/master/pom.xml#L604

      https://blog.codefx.org/java/java-9-migration-guide/#New-Version-Strings

      But that won't work if we need to use a version of 9+, where the version string is now just "9" etc

      In general we need multi-release JAR support here because if we change the way the java.level is handled then we don't inadvertently break Java 8 or earlier which expect the 1.x format.

        Attachments

          Activity

          svanoort Sam Van Oort created issue -
          svanoort Sam Van Oort made changes -
          Field Original Value New Value
          Epic Link JENKINS-40689 [ 177392 ]
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          I would vote against Java9-only plugins in short term.
          We likely need to get the Multi-Release JAR support in Jenkins tooling over the fence

          Show
          oleg_nenashev Oleg Nenashev added a comment - I would vote against Java9-only plugins in short term. We likely need to get the Multi-Release JAR support in Jenkins tooling over the fence
          Hide
          svanoort Sam Van Oort added a comment -

          I would agree with that being a better solution – perhaps I should rephrase the issue to better express the problem.

          Show
          svanoort Sam Van Oort added a comment - I would agree with that being a better solution – perhaps I should rephrase the issue to better express the problem.
          svanoort Sam Van Oort made changes -
          Summary Plugin-Pom Can't Handle New Java 9+ Version strings for java.level Plugin-Pom Uses Single Version String Hardcoded To Only Work With Java 8 or earlier
          svanoort Sam Van Oort made changes -
          Description Previously Java versions strings were 1.x, so the plugin-pom hardcodes a java.level property of "8" like so:

          <source>1.${java.level}</source>

          See: https://github.com/jenkinsci/plugin-pom/blob/master/pom.xml#L604

          https://blog.codefx.org/java/java-9-migration-guide/#New-Version-Strings

          But that won't work if we need to use a version of 9+, where the version string is now just "9" etc
          Previously Java versions strings were 1.x, so the plugin-pom hardcodes a java.level property of "8" like so:

          <source>1.${java.level}</source>

          See: https://github.com/jenkinsci/plugin-pom/blob/master/pom.xml#L604

          https://blog.codefx.org/java/java-9-migration-guide/#New-Version-Strings

          But that won't work if we need to use a version of 9+, where the version string is now just "9" etc

          In general we need multi-release JAR support here because if we change the way the java.level is handled *then* we don't inadvertently break Java 8 or earlier which expect the 1.x format.
          svanoort Sam Van Oort made changes -
          Summary Plugin-Pom Uses Single Version String Hardcoded To Only Work With Java 8 or earlier Plugin POM Uses Single Version String Hardcoded To Only Work With Java 8 or earlier
          miraha jang hyemi (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          miraha jang hyemi (Inactive) made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          oleg_nenashev Oleg Nenashev made changes -
          Labels java10 java10_hackathon java10 java10_hackathon java11
          oleg_nenashev Oleg Nenashev made changes -
          Labels java10 java10_hackathon java11 java10 java10_hackathon java11 java11-devtools-compatibility
          oleg_nenashev Oleg Nenashev made changes -
          Assignee Oleg Nenashev [ oleg_nenashev ]
          Show
          oleg_nenashev Oleg Nenashev added a comment - https://github.com/jenkinsci/plugin-pom/pull/133  
          batmat Baptiste Mathus made changes -
          Labels java10 java10_hackathon java11 java11-devtools-compatibility java10 java10_hackathon java11 java11-devtools-compatibility triaged

            People

            • Assignee:
              oleg_nenashev Oleg Nenashev
              Reporter:
              svanoort Sam Van Oort
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: