Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-52308

Update File Leak Detector and File Leak Detector Plugin to ASM 6.2

    Details

    • Similar Issues:

      Description

      Currently FileLeak Detector Plugin uses ASM 6.0-BETA, but in JENKINS-40689 we discovered that ASM 6.2 is required to support Java 10 in Pipeline and other logic. It makes sense to update the detector and the plugin to use new ASM API

        Attachments

          Activity

          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Actually it's just Nice 2 have, because the plugin uses the version from the core anyway: https://github.com/jenkinsci/file-leak-detector-plugin/blob/master/pom.xml#L33-L36

          Show
          oleg_nenashev Oleg Nenashev added a comment - Actually it's just Nice 2 have, because the plugin uses the version from the core anyway: https://github.com/jenkinsci/file-leak-detector-plugin/blob/master/pom.xml#L33-L36
          Hide
          francoisd Duane Francis added a comment - - edited

          Which file-leak-detector do we want to update to? 

          Current version is 7.1 for ASM

          3 March 2019: ASM 7.1 (tag ASM_7_1)

          Do we still want to check for 6.2 for ASM?

          Thanks

           

           

          Show
          francoisd Duane Francis added a comment - - edited Which file-leak-detector do we want to update to?  Current version is 7.1 for ASM 3 March 2019: ASM 7.1 (tag ASM_7_1) Do we still want to check for 6.2 for ASM? Thanks    
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          It would be better to keep the version aligned with Jenkins core. That version comes from https://github.com/kohsuke/package-renamed-asm/blob/asm6/pom.xml#L35 and now it is 6.2

          Updating to a newer version may make sense, but we will need to update ASM in the Jenkins core as well, I believe

           

          CC Baptiste Mathus Ramon Leon Adrien Lecharpentier

           

          Show
          oleg_nenashev Oleg Nenashev added a comment - It would be better to keep the version aligned with Jenkins core. That version comes from  https://github.com/kohsuke/package-renamed-asm/blob/asm6/pom.xml#L35  and now it is 6.2 Updating to a newer version may make sense, but we will need to update ASM in the Jenkins core as well, I believe   CC Baptiste Mathus Ramon Leon Adrien Lecharpentier  
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Removed the Triaged label so that the Java 11 Support Team reviews feasibility of the ASM 7 update

          Show
          oleg_nenashev Oleg Nenashev added a comment - Removed the Triaged label so that the Java 11 Support Team reviews feasibility of the ASM 7 update

            People

            • Assignee:
              francoisd Duane Francis
              Reporter:
              oleg_nenashev Oleg Nenashev
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: