Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-52902

Would a PR be accepted with a new "labelledShell" step, or an optional "label" argument to the "sh" step?

    Details

    • Similar Issues:
    • Released As:
      workflow-durable-task-step 2.28

      Description

      The motivation for this comes from JENKINS-36933 and JENKINS-37324.


      I created a small plugin at https://github.com/vickychijwani/labelled-steps-plugin (see HOSTING-606) that works identically to the sh step but allows for a custom label by implementing argumentsToString(). Quick example:

      labelledShell label: 'Building the universe from scratch...', script: """
          echo "Sparking the Big Bang..."
          echo "Cosmic inflation begins..."
          # ...
      """
      

      Would the maintainers of workflow-durable-task-step-plugin be willing to accept the labelledShell step into the existing plugin instead? Or even accept a patch to the sh step with an optional label argument? That way we could avoid having a separate plugin for what seems like highly-requested functionality. Please let me know, thanks.

        Attachments

          Issue Links

            Activity

            Hide
            reinholdfuereder Reinhold Füreder added a comment -

            This has been implemented and very recently released in "workflow-durable-task-step v2.28" via JENKINS-55410

            Show
            reinholdfuereder Reinhold Füreder added a comment - This has been implemented and very recently released in "workflow-durable-task-step v2.28" via JENKINS-55410
            Hide
            jglick Jesse Glick added a comment -

            Opinions vary. Personally I think it is the wrong design (that the ultimate need is better addressed in other ways).

            Show
            jglick Jesse Glick added a comment - Opinions vary. Personally I think it is the wrong design (that the ultimate need is better addressed in other ways).

              People

              • Assignee:
                Unassigned
                Reporter:
                vickychijwani Vicky Chijwani
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: