Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-53262

Folder URL forward slashes are double encoded for Outlook notifications

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Labels:
      None
    • Environment:
      Jenkins version 2.107.1

      Office 365 Connector Plugin version 4.5

      CloudBees Folders Plugin version 6.1.2

      Blue Ocean Plugin version 1.3.3
    • Similar Issues:

      Description

      For the "View Build" link in notification e-mails, forward slashes for folders in Blue Ocean job URL paths are encoded to a double forward slash instead of a single forward slash.

      Notification webhooks
      URL: https://outlook.office.com/webhook/e280b...

      Related issue: JENKINS-53261

        Attachments

          Activity

          Hide
          dnusbaum Devin Nusbaum added a comment - - edited

          I'm not sure why I am the default assignee here. It looks like Out conn is the maintainer of office-365-connector-plugin, so I am assigning it to him. It should be easy enough to check whether the bug is in that plugin or if the URL it gets from https://github.com/jenkinsci/blueocean-display-url-plugin has already been double-escaped in which case that plugin would need to be fixed.

          Also note: the problem is not 2 slashes (which would be %2f%2f), but that / was encoded twice: Once into %2f, and then the % was encoded again resulting in %252f

          Show
          dnusbaum Devin Nusbaum added a comment - - edited I'm not sure why I am the default assignee here. It looks like Out conn is the maintainer of office-365-connector-plugin, so I am assigning it to him. It should be easy enough to check whether the bug is in that plugin or if the URL it gets from https://github.com/jenkinsci/blueocean-display-url-plugin has already been double-escaped in which case that plugin would need to be fixed. Also note: the problem is not 2 slashes (which would be %2f%2f ), but that / was encoded twice: Once into %2f , and then the % was encoded again resulting in %252f
          Hide
          jacurt Jason Curtis added a comment -

          This Jenkins master is behind Apache with the rewrite module enabled, and rewrite directives configured. The double encoding problem was resolved by adding the NE flag to the RewriteRule directive to prevent mod_rewrite from applying hexcode escaping of special characters in the result of the rewrite. The forward slash ('/') characters are no longer being double encoded. Related links:

          https://httpd.apache.org/docs/current/mod/mod_rewrite.html#rewriterule

          https://httpd.apache.org/docs/2.4/rewrite/flags.html#flag_ne

          http://tkurek.blogspot.com/2013/06/252f-instead-of-2f-in-url-apache.html

           

          Show
          jacurt Jason Curtis added a comment - This Jenkins master is behind Apache with the rewrite module enabled, and rewrite directives configured. The double encoding problem was resolved by adding the NE flag to the RewriteRule directive to prevent mod_rewrite from applying hexcode escaping of special characters in the result of the rewrite. The forward slash ('/') characters are no longer being double encoded. Related links: https://httpd.apache.org/docs/current/mod/mod_rewrite.html#rewriterule https://httpd.apache.org/docs/2.4/rewrite/flags.html#flag_ne http://tkurek.blogspot.com/2013/06/252f-instead-of-2f-in-url-apache.html  

            People

            • Assignee:
              outconn Out conn
              Reporter:
              jacurt Jason Curtis
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: