Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-53327

Simple Theme Plugin v0.5 - CSS rule omitted by Jelly

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      After upgrading Simple Theme Plugin from version 0.4 to 0.5 on Jenkins ver. 2.107.3, the following simple CSS rule saved in the Theme global properties no longer works. I tried deleting and recreating the rule with no success.

      .pipeline-annotated {

          display: none;

      }

      The CSS rule suppresses pipeline output, as recommended in a comment on this issue:  JENKINS-41845 

      Developer Tobias Gruetzmacher further commented at https://wiki.jenkins.io/display/JENKINS/Simple+Theme+Plugin :

      This is indeed a bug, introduced by the refactoring work between 0.4 and 0.5: While https://github.com/jenkinsci/simple-theme-plugin/blob/simple-theme-plugin-0.4/src/main/resources/org/codefirst/SimpleThemeDecorator/header.jelly#L9-L11 and https://github.com/jenkinsci/simple-theme-plugin/blob/simple-theme-plugin-0.5/src/main/java/org/jenkinsci/plugins/simpletheme/CssTextThemeElement.java#L12 look the same, it seems Jelly helpfully removed the CDATA tags before, which it can't anymore, since the tags are inserted raw.

       

        Attachments

          Activity

          Hide
          stickycode Michael McCallum added a comment -

          I notice that on the 2.139 and 0.5 that the css in the header is now wrapped in a CDATA which stops it from working

          Show
          stickycode Michael McCallum added a comment - I notice that on the 2.139 and 0.5 that the css in the header is now wrapped in a CDATA which stops it from working
          Hide
          tgr Tobias Gruetzmacher added a comment -

          Michael McCallum Yes, the CDATA was there before, but Jelly "helpfully" removed it before rending the final page... I have now removed it.

          Show
          tgr Tobias Gruetzmacher added a comment - Michael McCallum Yes, the CDATA was there before, but Jelly "helpfully" removed it before rending the final page... I have now removed it.
          Hide
          psteiner Philip Steiner added a comment -

          I can confirm that the fix in v0.5.1 corrected the problem I reported - thanks for the speedy resolution!

          Show
          psteiner Philip Steiner added a comment - I can confirm that the fix in v0.5.1 corrected the problem I reported - thanks for the speedy resolution!

            People

            • Assignee:
              tgr Tobias Gruetzmacher
              Reporter:
              psteiner Philip Steiner
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: