Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5398

LabelBuilder needs an "@" on Revision:

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: perforce-plugin
    • Labels:
      None
    • Environment:
      Windows XP, Hudson 1.339 and 1.342, Perforce plugin 1.0.17
    • Similar Issues:

      Description

      Just updated to latest Perforce plugin 1.0.17 from a customized version of 1.0.16-snapshot. I have to modify the LabelBuilder.java file to add a "@" in the revision line. Not sure if this was the place to do it but it worked. If you label from Hudson the "Revision: " field gets the changelist properly but when you "Show List of Files" from p4gui you get "Unintelligible revision specification '35490'."

      svn info LabelBuilder.java
      Path: LabelBuilder.java
      Name: LabelBuilder.java
      URL: https://svn.dev.java.net/svn/hudson/trunk/hudson/plugins/perforce/src/main/java/com/tek42/perforce/parse/LabelBuilder.java
      Repository Root: https://svn.dev.java.net/svn/hudson
      Repository UUID: 71c3de6d-444a-0410-be80-ed276b4c234a
      Revision: 26518
      Node Kind: file
      Schedule: normal
      Last Changed Author: stimms
      Last Changed Rev: 18436
      Last Changed Date: 2009-05-26 13:21:07 -0400 (Tue, 26 May 2009)
      Text Last Updated: 2010-01-04 10:05:28 -0500 (Mon, 04 Jan 2010)
      Checksum: c833a35dbd3c7bce29dff8a7703830e8

      [scott@osmium parse]$ svn diff LabelBuilder.java
      Index: LabelBuilder.java
      ===================================================================
      — LabelBuilder.java (revision 26518)
      +++ LabelBuilder.java (working copy)
      @@ -91,7 +91,7 @@
      writer.write("Label: " + label.getName() + "\n");
      writer.write("Owner: " + label.getOwner() + "\n");
      writer.write("Description:\n\t" + label.getDescription() + "\n");

      • writer.write("Revision: " + label.getRevision() + "\n");
        + writer.write("Revision: @" + label.getRevision() + "\n");
        writer.write("Options: " + label.getOptions() + "\n");
        writer.write("View:\n");
        for(String view : label.getViews()) {

        Attachments

          Activity

          Hide
          riverofcode riverofcode added a comment -

          edit to change priority. I can modify the field in p4gui so I have a workaround.

          Show
          riverofcode riverofcode added a comment - edit to change priority. I can modify the field in p4gui so I have a workaround.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : rpetti
          Path:
          trunk/hudson/plugins/perforce/src/main/java/com/tek42/perforce/parse/LabelBuilder.java
          http://jenkins-ci.org/commit/26575
          Log:
          [FIXED JENKINS-5398] adding '@' to Revision field during label generation.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : rpetti Path: trunk/hudson/plugins/perforce/src/main/java/com/tek42/perforce/parse/LabelBuilder.java http://jenkins-ci.org/commit/26575 Log: [FIXED JENKINS-5398] adding '@' to Revision field during label generation.

            People

            • Assignee:
              Unassigned
              Reporter:
              riverofcode riverofcode
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: