Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54325

Support multiple SimplePageDecorators for login and signup page footers

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:
    • Released As:
      2.156

      Description

      In login.jelly, this uses SimplePageDecorator instead of the typical PageDecorator used on most other pages. The latter decorator supports registering multiple instances so that they can all be included in various pages. The former, however, only uses the first instance found. By doing this, plugins cannot override the default login page decorations without needlessly copying code from Jenkins Core to emulate it.

      What I'd like is for the login page to list out all registered decorators for the footer in order rather than just the first one.

      This also applies to the signup.jelly page.

        Attachments

          Issue Links

            Activity

            jvz Matt Sicker created issue -
            jvz Matt Sicker made changes -
            Field Original Value New Value
            Status Open [ 1 ] In Progress [ 3 ]
            jvz Matt Sicker made changes -
            Assignee Matt Sicker [ jvz ]
            jvz Matt Sicker made changes -
            Remote Link This issue links to "PR-3710 (Web Link)" [ 21966 ]
            jvz Matt Sicker made changes -
            Summary Support multiple SimplePageDecorators for login page Support multiple SimplePageDecorators for login and signup page
            jvz Matt Sicker made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            jvz Matt Sicker made changes -
            Description In {{login.jelly}}, this uses {{SimplePageDecorator}} instead of the typical {{PageDecorator}} used on most other pages. The latter decorator supports registering multiple instances so that they can all be included in various pages. The former, however, only uses the first instance found. By doing this, plugins cannot override the default login page decorations without needlessly copying code from Jenkins Core to emulate it.

            What I'd like is for the login page to list out all registered decorators in order rather than just the first one.
            In {{login.jelly}}, this uses {{SimplePageDecorator}} instead of the typical {{PageDecorator}} used on most other pages. The latter decorator supports registering multiple instances so that they can all be included in various pages. The former, however, only uses the first instance found. By doing this, plugins cannot override the default login page decorations without needlessly copying code from Jenkins Core to emulate it.

            What I'd like is for the login page to list out all registered decorators in order rather than just the first one.

            This also applies to the {{signup.jelly}} page.
            jvz Matt Sicker made changes -
            Summary Support multiple SimplePageDecorators for login and signup page Support multiple SimplePageDecorators for login and signup page footers
            jvz Matt Sicker made changes -
            Description In {{login.jelly}}, this uses {{SimplePageDecorator}} instead of the typical {{PageDecorator}} used on most other pages. The latter decorator supports registering multiple instances so that they can all be included in various pages. The former, however, only uses the first instance found. By doing this, plugins cannot override the default login page decorations without needlessly copying code from Jenkins Core to emulate it.

            What I'd like is for the login page to list out all registered decorators in order rather than just the first one.

            This also applies to the {{signup.jelly}} page.
            In {{login.jelly}}, this uses {{SimplePageDecorator}} instead of the typical {{PageDecorator}} used on most other pages. The latter decorator supports registering multiple instances so that they can all be included in various pages. The former, however, only uses the first instance found. By doing this, plugins cannot override the default login page decorations without needlessly copying code from Jenkins Core to emulate it.

            What I'd like is for the login page to list out all registered decorators for the footer in order rather than just the first one.

            This also applies to the {{signup.jelly}} page.
            wfollonier Wadeck Follonier made changes -
            Remote Link This issue links to "PR-3721 (supersedes 3710) (Web Link)" [ 22056 ]
            Hide
            jvz Matt Sicker added a comment -

            Released in 2.156, forgot to close this.

            Show
            jvz Matt Sicker added a comment - Released in 2.156, forgot to close this.
            jvz Matt Sicker made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Released As 2.156
            jvz Matt Sicker made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              • Assignee:
                jvz Matt Sicker
                Reporter:
                jvz Matt Sicker
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: