Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54466

HPIs should be renamed JPIs after download

    Details

    • Similar Issues:
    • Sprint:
      Evergreen - Milestone 2

      Description

      Problem statement

      During downloads, we put plugins as-is on the disk with their name and extension.
      Issue is, download URLs end with .hpi. This is inconsistent with what Jenkins does renaming to .jpi since ~1.5xx.
      I saw that a lot in JENKINS-54358, not sure where this comes from, but fixing it would at least avoid this situation in the future.

      Expected

      We should actively rename to .jpi after download.

        Attachments

          Issue Links

            Activity

            batmat Baptiste Mathus created issue -
            batmat Baptiste Mathus made changes -
            Field Original Value New Value
            Link This issue relates to JENKINS-54358 [ JENKINS-54358 ]
            batmat Baptiste Mathus made changes -
            Description h3. Problem statement

            During downloads, we put plugins as-is on the disk with their name and extension.
            Issue is, download URLs end with .hpi, and Jenkins renames it to .jpi in many cases since ~1.5xx. So on updates, and potential restarts, we can end up with both .hpi and .jpi.

            h3. Expected

            We should actively rename to .jpi after download.
            h3. Problem statement

            During downloads, we put plugins as-is on the disk with their name and extension.
            Issue is, download URLs end with .hpi, and Jenkins renames it to .jpi in many cases since ~1.5xx. So on updates, and potential restarts, we can end up with both .hpi and .jpi.
            I saw that a lot in JENKINS-54358

            h3. Expected

            We should actively rename to .jpi after download.
            batmat Baptiste Mathus made changes -
            Assignee R. Tyler Croy [ rtyler ] Baptiste Mathus [ batmat ]
            batmat Baptiste Mathus made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            batmat Baptiste Mathus made changes -
            Rank Ranked higher
            batmat Baptiste Mathus made changes -
            Description h3. Problem statement

            During downloads, we put plugins as-is on the disk with their name and extension.
            Issue is, download URLs end with .hpi, and Jenkins renames it to .jpi in many cases since ~1.5xx. So on updates, and potential restarts, we can end up with both .hpi and .jpi.
            I saw that a lot in JENKINS-54358

            h3. Expected

            We should actively rename to .jpi after download.
            h3. Problem statement

            During downloads, we put plugins as-is on the disk with their name and extension.
            Issue is, download URLs end with .hpi. This is inconsistent with what Jenkins does renaming to .jpi since ~1.5xx.
            I saw that a lot in JENKINS-54358, not sure where this comes from, but fixing it would at least avoid this situation in the future.

            h3. Expected

            We should actively rename to .jpi after download.
            Hide
            batmat Baptiste Mathus added a comment -

            Also TODO: check that the core issues a warning if both .jpi and .hpi are present for a given plugin.

            Show
            batmat Baptiste Mathus added a comment - Also TODO: check that the core issues a warning if both .jpi and .hpi are present for a given plugin.
            Hide
            batmat Baptiste Mathus added a comment -

            Almost there FTR. Fixing a few tests here and there that were expecting .hpi. Slightly more than just replaceAll, since we actually want to detect if someone put an hpi by hand for instance, and not just ignore these files when reporting versions for example.

            Show
            batmat Baptiste Mathus added a comment - Almost there FTR. Fixing a few tests here and there that were expecting .hpi. Slightly more than just replaceAll, since we actually want to detect if someone put an hpi by hand for instance, and not just ignore these files when reporting versions for example.
            batmat Baptiste Mathus made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            batmat Baptiste Mathus made changes -
            Remote Link This issue links to "evergreen PR (Web Link)" [ 22022 ]
            batmat Baptiste Mathus made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]

              People

              • Assignee:
                batmat Baptiste Mathus
                Reporter:
                batmat Baptiste Mathus
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: