Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5452

Whitespace in the user ID

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Looking at page like http://deadlock.netbeans.org/hudson/job/trunk/7635/changes, there is a whitespace at the end of the user name "Alex Petrov " in this case.

      I can't spot if this is caused by the core or by the plugin, but such whitespace should be trimmed.

        Attachments

          Issue Links

            Activity

            kohsuke Kohsuke Kawaguchi created issue -
            Hide
            jglick Jesse Glick added a comment -

            For a User whose fullName is 'Bob Hacker <bhacker@netbeans.org>' (legitimate AFAIK), this Jelly code:

            <a href="${rootURL}/${cs.author.url}/">${cs.author}</a>
            

            produces this HTML:

            <a style="" href="/hudson/user/Bob%20Hacker%20_bhacker@netbeans.org_/">Bob Hacker <bhacker@netbeans.org></bhacker@netbeans.org></a>
            

            which is clearly wrong. What should be used to emit text while escaping HTML metacharacters?

            Show
            jglick Jesse Glick added a comment - For a User whose fullName is 'Bob Hacker <bhacker@netbeans.org>' (legitimate AFAIK), this Jelly code: <a href="${rootURL}/${cs.author.url}/">${cs.author}</a> produces this HTML: <a style="" href="/hudson/user/Bob%20Hacker%20_bhacker@netbeans.org_/">Bob Hacker <bhacker@netbeans.org></bhacker@netbeans.org></a> which is clearly wrong. What should be used to emit text while escaping HTML metacharacters?
            Hide
            evernat evernat added a comment -

            This is currently reproductible with Hudson v1.392.
            See for example, http://deadlock.netbeans.org/hudson/job/trunk/10616/changes or another build.

            Show
            evernat evernat added a comment - This is currently reproductible with Hudson v1.392. See for example, http://deadlock.netbeans.org/hudson/job/trunk/10616/changes or another build.
            Hide
            integer Kanstantsin Shautsou added a comment -

            Is it actual? How reproduce? Any screenshots?

            Show
            integer Kanstantsin Shautsou added a comment - Is it actual? How reproduce? Any screenshots?
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Assignee Kohsuke Kawaguchi [ kohsuke ] Jesse Glick [ jglick ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/resources/hudson/plugins/mercurial/MercurialChangeSetList/index.jelly
            http://jenkins-ci.org/commit/mercurial-plugin/89f9e5fd842595ed8e0afc1196e53c8690436c63
            Log:
            [FIXED JENKINS-5452] Lack of proper escaping broke display of user names in changelog.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/resources/hudson/plugins/mercurial/MercurialChangeSetList/index.jelly http://jenkins-ci.org/commit/mercurial-plugin/89f9e5fd842595ed8e0afc1196e53c8690436c63 Log: [FIXED JENKINS-5452] Lack of proper escaping broke display of user names in changelog.
            scm_issue_link SCM/JIRA link daemon made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-16184 [ JENKINS-16184 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 135541 ] JNJira + In-Review [ 186993 ]

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                kohsuke Kohsuke Kawaguchi
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: