Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54576

hockeapp-plugin fails in pipeline because of missing 'baseUrlHolder'

    Details

    • Similar Issues:

      Description

      I try running the following step (generated by the snippet generator):

            steps {
              hockeyApp applications: [
                                        [
                                          apiToken: 'xxxxxx', 
                                          downloadAllowed: true, 
                                          filePath: '**/app-beta.apk', 
                                          mandatory: false, 
                                          notifyTeam: false, 
                                          releaseNotesMethod: none(), 
                                          uploadMethod: 
                                          versionCreation(appId: 'yyyyyy')
                                        ]
                                      ], 
                        debugMode: false, 
                        failGracefully: false
            }
      

      I get the following error:

      org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
      WorkflowScript: 27: Missing required parameter: "baseUrlHolder" @ line 27, column 9.
                 hockeyApp applications: [[apiToken: 'xxxxxx', downloadAllowed: true, filePath: '**/app-beta.apk', mandatory: false, notifyTeam: false, releaseNotesMethod: none(), uploadMethod: versionCreation(appId: 'yyyyyy')]], debugMode: false, failGracefully: false
                 ^
      
      1 error
      

        Attachments

          Activity

          Hide
          mezpahlan Mez Pahlan added a comment -

          Dominik Bartholdi thanks for reporting this. I can see what's happening. We are not handling the optional baseUrlHolder parameter correctly. I will look at a fix for this. Stay tuned. 

          In the meantime can you try setting the existing default value as: 

          baseUrlHolder: [baseUrl: 'https://rink.hockeyapp.net']

          Which isn't the nicest of syntax but we will look to make this prettier in the 2.x release.

          Show
          mezpahlan Mez Pahlan added a comment - Dominik Bartholdi thanks for reporting this. I can see what's happening. We are not handling the optional baseUrlHolder parameter correctly. I will look at a fix for this. Stay tuned.  In the meantime can you try setting the existing default value as:  baseUrlHolder: [baseUrl: 'https://rink.hockeyapp.net'] Which isn't the nicest of syntax but we will look to make this prettier in the 2.x release.
          Hide
          imod Dominik Bartholdi added a comment -

          Mez Pahlan thanks, that works for now

          Show
          imod Dominik Bartholdi added a comment - Mez Pahlan thanks, that works for now
          Hide
          mezpahlan Mez Pahlan added a comment -

          Hi Dominik Bartholdi I've made some changes that should render the baseUrlHolder / baseUrl completely optional if not specified. Are you able to test these changes out? You can get an updated plugin from the PR branch artefacts.

          The PR itself is on Github #58.

          Show
          mezpahlan Mez Pahlan added a comment - Hi Dominik Bartholdi I've made some changes that should render the baseUrlHolder / baseUrl completely optional if not specified. Are you able to test these changes out? You can get an updated plugin from the PR branch artefacts . The PR itself is on Github #58 .
          Hide
          imod Dominik Bartholdi added a comment -

          Mez Pahlan I commented directly on the PR

          Show
          imod Dominik Bartholdi added a comment - Mez Pahlan I commented directly on the PR

            People

            • Assignee:
              mezpahlan Mez Pahlan
              Reporter:
              imod Dominik Bartholdi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: