Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54904

"(hide)" and "(show)" links in console broken in Firefox

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: workflow-job-plugin
    • Labels:
      None
    • Environment:
      Jenkins core 2.153
      workflow-job 2.29
      (latest versions of all installed plugins like pipeline as of 27.11.2018)
    • Similar Issues:
    • Released As:
      workflow-job 2.30

      Description

      From JENKINS-41845

      The recently ("introduced in workflow-job 2.26") added ability to collapse sections with "(hide)" links in console view of classic UI does not work:

      1. Initial

      2. After clicking on "(hide)" link

      Unless I don't understand the feature? I expected that the "(hide)" links (that only appear via mouse over) allow to collapse the corresponding "nodes", and "(show)" links re-expand them? (In the screenshots above therefore the text "Build (#95): 20181127-093111-revUNKNOWN".

        Attachments

          Issue Links

            Activity

            reinholdfuereder Reinhold Füreder created issue -
            abayer Andrew Bayer made changes -
            Field Original Value New Value
            Component/s workflow-job-plugin [ 21716 ]
            Component/s pipeline [ 21692 ]
            jglick Jesse Glick made changes -
            Assignee Jesse Glick [ jglick ]
            Hide
            jglick Jesse Glick added a comment -

            Working for me last I checked. Perhaps certain scripts do not work this way, or perhaps it does not work on certain browsers, or perhaps there are some errors in your browser console.

            Show
            jglick Jesse Glick added a comment - Working for me last I checked. Perhaps certain scripts do not work this way, or perhaps it does not work on certain browsers, or perhaps there are some errors in your browser console.
            Hide
            reinholdfuereder Reinhold Füreder added a comment -

            Sorry for my incomplete report and congrats to your great intuition:

            • Firefox 63.0.3
            • Browser console shows this error:
              TypeError: ss.rules is undefined[Weitere Informationen] 5 script.js:37:25
              	showHide https://jenkins.acme.com/static/cf22a270/descriptor/org.jenkinsci.plugins.workflow.job.console.NewNodeConsoleNote/script.js:37:25
              	showHidePipelineSection https://jenkins.acme.com/static/cf22a270/descriptor/org.jenkinsci.plugins.workflow.job.console.NewNodeConsoleNote/script.js:45:5
              	onclick https://jenkins.acme.com/job/Sandbox/job/acme.stage/95/console:1:1 
            Show
            reinholdfuereder Reinhold Füreder added a comment - Sorry for my incomplete report and congrats to your great intuition: Firefox 63.0.3 Browser console shows this error: TypeError: ss.rules is undefined[Weitere Informationen] 5 script.js:37:25 showHide https: //jenkins.acme.com/ static /cf22a270/descriptor/org.jenkinsci.plugins.workflow.job.console.NewNodeConsoleNote/script.js:37:25 showHidePipelineSection https: //jenkins.acme.com/ static /cf22a270/descriptor/org.jenkinsci.plugins.workflow.job.console.NewNodeConsoleNote/script.js:45:5 onclick https: //jenkins.acme.com/job/Sandbox/job/acme.stage/95/console:1:1
            Hide
            jglick Jesse Glick added a comment -

            OK, not sure yet if I will be able to reproduce that, but looks easy enough to fix.

            Show
            jglick Jesse Glick added a comment - OK, not sure yet if I will be able to reproduce that, but looks easy enough to fix.
            Hide
            jglick Jesse Glick added a comment -

            Indeed it did not work in Firefox.

            Show
            jglick Jesse Glick added a comment - Indeed it did not work in Firefox.
            jglick Jesse Glick made changes -
            Summary "(hide)" and "(show)" links in console view of pipelines don't work "(hide)" and "(show)" links in console broken in Firefox
            Priority Minor [ 4 ] Major [ 3 ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "PR 121 (Web Link)" [ 22069 ]
            jglick Jesse Glick made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            Hide
            jglick Jesse Glick added a comment -

            If you could try the “incremental” build from that PR and confirm it works, I would appreciate it.

            Show
            jglick Jesse Glick added a comment - If you could try the “incremental” build from that PR and confirm it works, I would appreciate it.
            Hide
            reinholdfuereder Reinhold Füreder added a comment -

            Thanks for the quick fix: yes, it works as expected

            Show
            reinholdfuereder Reinhold Füreder added a comment - Thanks for the quick fix: yes, it works as expected
            Hide
            dnusbaum Devin Nusbaum added a comment -

            This should be fixed in version 2.30 of the Pipeline Job Plugin, which was just released.

            Show
            dnusbaum Devin Nusbaum added a comment - This should be fixed in version 2.30 of the Pipeline Job Plugin, which was just released.
            dnusbaum Devin Nusbaum made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Released As workflow-job 2.30

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                reinholdfuereder Reinhold Füreder
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: