Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54934

Max number of retries and retry wait time do not allow 0

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: ssh-slaves-plugin
    • Labels:
      None
    • Environment:
      - Jenkins Version: v2.138.1
      - SSH Slaves Plugin: v1.28.1
      - Jenkins Master: Windows 7 (x64), running Oracle JDK 1.8.0-181
      - Jenkins Agents: Linux (x64)
    • Similar Issues:
    • Released As:
      ssh-slaves-1.29.2

      Description

      In SSH Slaves Plugin v1.28.1 it's no longer possible to set the max. number of retries and retry wait time to 0. The Agent configuration UI accepts the 0 but silently changes it back to the default values (that are 10 respectively 15).

       

      The change has been introduced with f68802b78084bee36f1fd8ab074178875b381063, related to JENKINS-52739 (included in v1.27). It worked previously in v1.26.

        Attachments

          Issue Links

            Activity

            Hide
            ifernandezcalvo Ivan Fernandez Calvo added a comment - - edited

            What is the use case to do not try at least one time to reconnect to the agent?

            Show
            ifernandezcalvo Ivan Fernandez Calvo added a comment - - edited What is the use case to do not try at least one time to reconnect to the agent?
            Hide
            ethorsa ethorsa added a comment - - edited

            A very fragile proprietary connection management to HW Agents. If a lost connection is retried, the build will fail by an EOFException after some minutes. Setting the mentioned values to 0 prevents the issue (though, this is not a real solution anyway).

            Show
            ethorsa ethorsa added a comment - - edited A very fragile proprietary connection management to HW Agents. If a lost connection is retried, the build will fail by an EOFException after some minutes. Setting the mentioned values to 0 prevents the issue (though, this is not a real solution anyway).
            Hide
            ethorsa ethorsa added a comment -

            There's a PR now.

            Show
            ethorsa ethorsa added a comment - There's a PR now.
            Hide
            ethorsa ethorsa added a comment -

            Ivan Fernandez Calvo can we close here? The changes are reviewed and merged.

            Show
            ethorsa ethorsa added a comment - Ivan Fernandez Calvo can we close here? The changes are reviewed and merged.
            Hide
            ifernandezcalvo Ivan Fernandez Calvo added a comment -

            I use to close the issues when I release the plugin

            Show
            ifernandezcalvo Ivan Fernandez Calvo added a comment - I use to close the issues when I release the plugin

              People

              • Assignee:
                ifernandezcalvo Ivan Fernandez Calvo
                Reporter:
                ethorsa ethorsa
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: