Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54998

Stash and archive should refuse symlinks

    Details

    • Similar Issues:

      Description

      Stash and archive should follow symlinks. Otherwise a symlink that the pipeline tries to archive is broken, a broken symlink is unstashed, unarchived or copied from another job, an error should be thrown.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            Presence of symlinks or other special files in the input should just be treated as an error.

            Show
            jglick Jesse Glick added a comment - Presence of symlinks or other special files in the input should just be treated as an error.
            Hide
            oesolutions Chris Dore added a comment -

            Jesse Glick why should a symlink be an error?

            Since symlinks are not preserved, we abandoned using stash and instead we are now allocating a node for the entire pipeline, even when that node could be released back to the pool during certain stages. I would love to revisit our workaround and improve node utilization, having stash handle symlinks would make this very easy. Are there other alternative ideas to allow a pipeline to save state containing symlinks across stages on different nodes/workspaces?

            Show
            oesolutions Chris Dore added a comment - Jesse Glick why should a symlink be an error? Since symlinks are not preserved, we abandoned using stash and instead we are now allocating a node for the entire pipeline, even when that node could be released back to the pool during certain stages. I would love to revisit our workaround and improve node utilization, having stash handle symlinks would make this very easy. Are there other alternative ideas to allow a pipeline to save state containing symlinks across stages on different nodes/workspaces?
            Hide
            jglick Jesse Glick added a comment -

            Use tar and decide in your script which options to pass to get the desired behavior: preserving symlinks, preserving other special files, preserving owner, preserving mode, etc.

            Show
            jglick Jesse Glick added a comment - Use tar and decide in your script which options to pass to get the desired behavior: preserving symlinks, preserving other special files, preserving owner, preserving mode, etc.

              People

              • Assignee:
                Unassigned
                Reporter:
                neothethird Jan Sprinz
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: