Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55050

Performance improvement for large archive symlink outside of workspace

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:
    • Released As:
      Jenkins 2.164

      Description

      When an archive contain a symlink that is leading outside of the workspace, the current implementation check if the linked folder and every descendants in that folder are inside the workspace, causing some performance troubles if there are really numerous. Those checks are performed when we want to download the zip containing the specific symlink.

      This case is mostly encountered when an undesired symlink is created.

        Attachments

          Activity

          Hide
          wfollonier Wadeck Follonier added a comment -

          Script attached to generate 4013 files inside a complex structure of folders.
          With log in INFO level, time to download the zip of that directory: 10-12s

          First approach:
          By just setting the log to FINE, time down to: 6-7s

          Show
          wfollonier Wadeck Follonier added a comment - Script attached to generate 4013 files inside a complex structure of folders. With log in INFO level, time to download the zip of that directory: 10-12s First approach: By just setting the log to FINE, time down to: 6-7s
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          It was released in 2.164. If a previous version is selected as an LTS baseline, we may need backporting

          Show
          oleg_nenashev Oleg Nenashev added a comment - It was released in 2.164. If a previous version is selected as an LTS baseline, we may need backporting

            People

            • Assignee:
              wfollonier Wadeck Follonier
              Reporter:
              wfollonier Wadeck Follonier
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: