Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55150

[jenkins-dev] jenkins-dev:run no longer has hot reload after 2.152

    Details

    • Similar Issues:

      Description

      Previously, when I ran mvn jenkins-dev:run the instance was running and the Jelly view (and re-compiled classes) were reloaded automatically.

      Since the 2.152 and the PR#3758, the things changed. The documentation cannot be used any longer.

      On 2.152+:

      • mvn jenkins-dev:run starts the instance but the hot reload feature does not work, even after pressing enter (was not required before). At least the jelly views are the ones from src.
      • mvn jenkins-dev:run -f war starts the instance but with the jelly views packaged in the war during a previous mvn clean install -DskipTests. No hot reload.

      After the migration, the mvn jenkins-dev:run is no longer working for 2.151- instances, the log hangs at "Started Jetty Server" forever. I am forced to run with -f war now in order to make it working.

      Request: please re-enable the hot reload feature.

      Ping Oleg Nenashev and Olivier Lamy for their Jetty knowledge.

       

      Acceptance criteria

      • understand the reason this was originally patched
      • fix the issue...

        Attachments

          Issue Links

            Activity

            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            I assume it is related to Java 11 patches in JENKINS-54599.

            It was working for me, but I did not check the auto-reload of resources

            Show
            oleg_nenashev Oleg Nenashev added a comment - I assume it is related to Java 11 patches in JENKINS-54599 . It was working for me, but I did not check the auto-reload of resources
            Hide
            oleg_nenashev Oleg Nenashev added a comment - - edited

            https://github.com/jenkinsci/maven-hudson-dev-plugin/pull/9 is a "root cause". Our plugin is a copy-paste of the Jetty dev plugin. Apparently it had some custom patches which I missed

             

            Show
            oleg_nenashev Oleg Nenashev added a comment - - edited https://github.com/jenkinsci/maven-hudson-dev-plugin/pull/9  is a "root cause". Our plugin is a copy-paste of the Jetty dev plugin. Apparently it had some custom patches which I missed  
            Hide
            batmat Baptiste Mathus added a comment -

            Maybe we should consider using at some point the upstream plugin, instead of using a fork?

             

             

            Show
            batmat Baptiste Mathus added a comment - Maybe we should consider using at some point the upstream plugin, instead of using a fork?    
            Hide
            danielbeck Daniel Beck added a comment -

            During development of https://github.com/jenkinsci/jenkins/pull/3919 (parent 0dfe346c9c1ccfcc2cca54c64f2850a2a5513d1a) I noticed that the Groovy views did not reload anymore with jenkins-dev:run. Very annoying.

            Show
            danielbeck Daniel Beck added a comment - During development of https://github.com/jenkinsci/jenkins/pull/3919 (parent 0dfe346c9c1ccfcc2cca54c64f2850a2a5513d1a) I noticed that the Groovy views did not reload anymore with jenkins-dev:run . Very annoying.
            Hide
            danielbeck Daniel Beck added a comment -

            Workaround seems to be running:

            mvn org.jenkins-ci.tools:maven-jenkins-dev-plugin:9.4.5.v20170502-jenkins-1:run

            Show
            danielbeck Daniel Beck added a comment - Workaround seems to be running: mvn org.jenkins-ci.tools:maven-jenkins-dev-plugin:9.4.5.v20170502-jenkins-1:run
            Hide
            timja Tim Jacomb added a comment -

            The workaround doesn't seem to be working for me Daniel Beck
            it just hangs here:

            [INFO] Started o.e.j.m.p.JettyWebAppContext@67b8d45{/,file:///Users/timja/projects/jenkinsci/jenkins/target/webapp-tmp/,AVAILABLE}{file:///Users/timja/projects/jenkinsci/jenkins/target/webapp-tmp/}
            [INFO] Started ServerConnector@2e44cb34{HTTP/1.1,[http/1.1]}{0.0.0.0:8080}
            [INFO] Started @10823ms
            [INFO] Started Jetty Server
            

            The regular approach works but no hot reload

            mvn jenkins-dev:run
            

            $ mvn --version
            Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T20:00:29+01:00)
            Maven home: /usr/local/Cellar/maven/3.6.1/libexec
            Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_202.jdk/Contents/Home/jre
            Default locale: en_GB, platform encoding: UTF-8
            OS name: "mac os x", version: "10.14.5", arch: "x86_64", family: "mac"

            Jenkins 2.188-SNAPSHOT

            Show
            timja Tim Jacomb added a comment - The workaround doesn't seem to be working for me Daniel Beck it just hangs here: [INFO] Started o.e.j.m.p.JettyWebAppContext@67b8d45{/,file: ///Users/timja/projects/jenkinsci/jenkins/target/webapp-tmp/,AVAILABLE}{file:///Users/timja/projects/jenkinsci/jenkins/target/webapp-tmp/} [INFO] Started ServerConnector@2e44cb34{HTTP/1.1,[http/1.1]}{0.0.0.0:8080} [INFO] Started @10823ms [INFO] Started Jetty Server The regular approach works but no hot reload mvn jenkins-dev:run $ mvn --version Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T20:00:29+01:00) Maven home: /usr/local/Cellar/maven/3.6.1/libexec Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_202.jdk/Contents/Home/jre Default locale: en_GB, platform encoding: UTF-8 OS name: "mac os x", version: "10.14.5", arch: "x86_64", family: "mac" Jenkins 2.188-SNAPSHOT
            Hide
            jglick Jesse Glick added a comment -

            Should be irrelevant after jenkins #4351.

            Show
            jglick Jesse Glick added a comment - Should be irrelevant after jenkins #4351 .

              People

              • Assignee:
                Unassigned
                Reporter:
                wfollonier Wadeck Follonier
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: