Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55738

NodeMonitor out of disk space message is wrong for master

    XMLWordPrintable

    Details

    • Similar Issues:
    • Released As:
      Jenkins 2.164

      Description

      When the master goes out of disk space, it is put offline by the hudson.node_monitors.AbstractDiskSpaceMonitor system.

      The message has a blank where the node name should be:

      Putting back online as there is enough disk space again

      I think this is just because c.getName() returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.

      Acceptance criteria

      • This should show master instead of a space as the node name, i.e.

      Putting back master online as there is enough disk space

        Attachments

        1. Capture1.JPG
          Capture1.JPG
          59 kB
        2. Capture1.JPG
          Capture1.JPG
          59 kB
        3. Capture2.JPG
          Capture2.JPG
          125 kB
        4. Capture2 - Copy.JPG
          Capture2 - Copy.JPG
          193 kB
        5. Capture3.JPG
          Capture3.JPG
          121 kB
        6. Capture3 - Copy.JPG
          Capture3 - Copy.JPG
          181 kB
        7. Capture4 - Copy.JPG
          Capture4 - Copy.JPG
          127 kB
        8. Capture5 - Copy.JPG
          Capture5 - Copy.JPG
          159 kB
        9. image-2019-02-09-00-30-55-101.png
          image-2019-02-09-00-30-55-101.png
          193 kB

          Activity

          Hide
          nisarg14 Nisarg Shah added a comment -

          Baptiste Mathus

          I have tested he fix and attaching screenshot of the output of Jenkins Window and CLI.

          And I think this fix has resolved the issue of displaying null message.

           

           

          Show
          nisarg14 Nisarg Shah added a comment - Baptiste Mathus I have tested he fix and attaching screenshot of the output of Jenkins Window and CLI. And I think this fix has resolved the issue of displaying null message.    
          Hide
          batmat Baptiste Mathus added a comment -

          Nisarg Shah the goal here is to fix the message explained in the description.

          See the acceptance criteria above.
          You need to see how Jenkins reacts when you remove the big files and have enough disk space again.

          Show
          batmat Baptiste Mathus added a comment - Nisarg Shah the goal here is to fix the message explained in the description. See the acceptance criteria above. You need to see how Jenkins reacts when you remove the big files and have enough disk space again.
          Hide
          nisarg14 Nisarg Shah added a comment -

          Baptiste Mathus

          I am attaching the screenshot of the message before the fix : 

          I have marked the issue with red marker.

          Show
          nisarg14 Nisarg Shah added a comment - Baptiste Mathus I am attaching the screenshot of the message before the fix :  I have marked the issue with red marker.
          Hide
          nisarg14 Nisarg Shah added a comment -

          Baptiste Mathus

          I am attaching the screenshot of message after the fix.

          And I think the issue is solved as per acceptance criteria.

           

          Show
          nisarg14 Nisarg Shah added a comment - Baptiste Mathus I am attaching the screenshot of message after the fix. And I think the issue is solved as per acceptance criteria.  
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          The fix has been released in Jenkins 2.164. Thanks Nisarg Shah!

          Show
          oleg_nenashev Oleg Nenashev added a comment - The fix has been released in Jenkins 2.164. Thanks Nisarg Shah !

            People

            • Assignee:
              nisarg14 Nisarg Shah
              Reporter:
              batmat Baptiste Mathus
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: