Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55738

NodeMonitor out of disk space message is wrong for master

    Details

    • Similar Issues:
    • Released As:
      Jenkins 2.164

      Description

      When the master goes out of disk space, it is put offline by the hudson.node_monitors.AbstractDiskSpaceMonitor system.

      The message has a blank where the node name should be:

      Putting back online as there is enough disk space again

      I think this is just because c.getName() returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.

      Acceptance criteria

      • This should show master instead of a space as the node name, i.e.

      Putting back master online as there is enough disk space

        Attachments

        1. Capture1.JPG
          Capture1.JPG
          59 kB
        2. Capture1.JPG
          Capture1.JPG
          59 kB
        3. Capture2.JPG
          Capture2.JPG
          125 kB
        4. Capture2 - Copy.JPG
          Capture2 - Copy.JPG
          193 kB
        5. Capture3.JPG
          Capture3.JPG
          121 kB
        6. Capture3 - Copy.JPG
          Capture3 - Copy.JPG
          181 kB
        7. Capture4 - Copy.JPG
          Capture4 - Copy.JPG
          127 kB
        8. Capture5 - Copy.JPG
          Capture5 - Copy.JPG
          159 kB
        9. image-2019-02-09-00-30-55-101.png
          image-2019-02-09-00-30-55-101.png
          193 kB

          Activity

          batmat Baptiste Mathus created issue -
          batmat Baptiste Mathus made changes -
          Field Original Value New Value
          Description When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system.

          The message has a blank where the node name should be:

          {{Putting back online as there is enough disk space again}}


          I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.

          h3. Acceptance criteria

          * This should show {{master}} instead of a space as the node name
          When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system.

          The message has a blank where the node name should be:

          {{Putting back online as there is enough disk space again}}


          I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.

          h3. Acceptance criteria

          * This should show {{master}} instead of a space as the node name
          batmat Baptiste Mathus made changes -
          Description When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system.

          The message has a blank where the node name should be:

          {{Putting back online as there is enough disk space again}}


          I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.

          h3. Acceptance criteria

          * This should show {{master}} instead of a space as the node name
          When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system.

          The message has a blank where the node name should be:

          {{Putting back online as there is enough disk space again}}


          I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.

          h3. Acceptance criteria

          * This should show {{master}} instead of a space as the node name
          nisarg14 Nisarg Shah made changes -
          Assignee Nisarg Shah [ nisarg14 ]
          nisarg14 Nisarg Shah made changes -
          Comment [ Okay and Can I get just one help that how can I test my change in code. Like how would i run that code and check whether that issue has solved or not? ]
          batmat Baptiste Mathus made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          nisarg14 Nisarg Shah made changes -
          Attachment Capture1.JPG [ 45958 ]
          nisarg14 Nisarg Shah made changes -
          Comment [ I have tested this fix and I am attaching the screenshot of the result obtained. !Capture1.JPG! ]
          nisarg14 Nisarg Shah made changes -
          Comment [ [~batmat]

          I have tested the fix and I am attaching the screenshot of the result obtained.

          !Capture1.JPG|thumbnail! ]
          nisarg14 Nisarg Shah made changes -
          Attachment Capture2.JPG [ 45959 ]
          nisarg14 Nisarg Shah made changes -
          Attachment Capture1.JPG [ 45960 ]
          batmat Baptiste Mathus made changes -
          Description When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system.

          The message has a blank where the node name should be:

          {{Putting back online as there is enough disk space again}}


          I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.

          h3. Acceptance criteria

          * This should show {{master}} instead of a space as the node name
          When the master goes out of disk space, it is put offline by the {{hudson.node_monitors.AbstractDiskSpaceMonitor}} system.

          The message has a blank where the node name should be:

          {{Putting back online as there is enough disk space again}}


          I think this is just because {{c.getName()}} returns an empty string in https://github.com/jenkinsci/jenkins/blob/9d61a9a13171c94e55779d166d81599cdd0f9cb7/core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java#L43-L71.

          h3. Acceptance criteria

          * This should show {{master}} instead of a space as the node name, i.e.

          {{Putting back *master* online as there is enough disk space}}
          nisarg14 Nisarg Shah made changes -
          Attachment Capture3.JPG [ 45977 ]
          nisarg14 Nisarg Shah made changes -
          Attachment Capture3 - Copy.JPG [ 45978 ]
          nisarg14 Nisarg Shah made changes -
          Attachment Capture4 - Copy.JPG [ 45979 ]
          nisarg14 Nisarg Shah made changes -
          Attachment Capture2 - Copy.JPG [ 45980 ]
          nisarg14 Nisarg Shah made changes -
          Attachment image-2019-02-09-00-30-55-101.png [ 45981 ]
          nisarg14 Nisarg Shah made changes -
          Comment [ [~batmat]

          I am attaching screenshot of message after the fix.

          First photo is when there was an out of disk event detected.

          Second photo is when master node came online as the disk gets some empty space.

          And I think this fulfills the acceptance criteria.

           

          !image-2019-02-09-00-30-55-101.png|width=735,height=370!

           

          !Capture4 - Copy.JPG|width=598,height=263!

           

            ]
          nisarg14 Nisarg Shah made changes -
          Attachment Capture5 - Copy.JPG [ 45982 ]
          batmat Baptiste Mathus made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          oleg_nenashev Oleg Nenashev made changes -
          Labels evergreen-triggered fosdem2019 newbie-friendly evergreen-triggered fosdem2019 lts-candidate newbie-friendly
          oleg_nenashev Oleg Nenashev made changes -
          Status In Review [ 10005 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Released As Jenkins 2.164
          olivergondza Oliver Gond┼ża made changes -
          Labels evergreen-triggered fosdem2019 lts-candidate newbie-friendly evergreen-triggered fosdem2019 newbie-friendly

            People

            • Assignee:
              nisarg14 Nisarg Shah
              Reporter:
              batmat Baptiste Mathus
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: