Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55803

Performance: Replace RoleMap#getRolesHavingPermission() usages by iterators

    Details

    • Similar Issues:
    • Released As:
      Role Strategy 2.10

      Description

      See https://github.com/jenkinsci/role-strategy-plugin/blob/a2069c1fcb56ff0cd8b80a0655931f5974634eee/src/main/java/com/michelin/cio/hudson/plugins/rolestrategy/RoleMap.java#L353 

      Each time the method is invoked, a new intermediate collection is created. Instead of such implementation, it would be preferable to have calling logic to be executed in the RoleWalker directly. RoleMap#hasPermission() method could be refactored in such way so that it has lower memory footprint and performance overheads

       

        Attachments

          Activity

          oleg_nenashev Oleg Nenashev created issue -
          oleg_nenashev Oleg Nenashev made changes -
          Field Original Value New Value
          Epic Link JENKINS-18377 [ 149684 ]
          oleg_nenashev Oleg Nenashev made changes -
          Summary Performance: Replace RoleMap#getRolesHavingPermission() usages by iteratos Performance: Replace RoleMap#getRolesHavingPermission() usages by iterators
          oleg_nenashev Oleg Nenashev made changes -
          Assignee Oleg Nenashev [ oleg_nenashev ]
          deepansh_nagaria Deepansh Nagaria made changes -
          Assignee Deepansh Nagaria [ deepansh_nagaria ]
          deepansh_nagaria Deepansh Nagaria made changes -
          Assignee Deepansh Nagaria [ deepansh_nagaria ] Oleg Nenashev [ oleg_nenashev ]
          deepansh_nagaria Deepansh Nagaria made changes -
          Assignee Oleg Nenashev [ oleg_nenashev ] Deepansh Nagaria [ deepansh_nagaria ]
          Hide
          deepansh_nagaria Deepansh Nagaria added a comment -

          I attempted this issue. Here's the pr: https://github.com/jenkinsci/role-strategy-plugin/pull/54 please correct me where ever required.

          Show
          deepansh_nagaria Deepansh Nagaria added a comment - I attempted this issue. Here's the pr: https://github.com/jenkinsci/role-strategy-plugin/pull/54 please correct me where ever required.
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          It was released in Role Strategy 2.10

          Show
          oleg_nenashev Oleg Nenashev added a comment - It was released in Role Strategy 2.10
          oleg_nenashev Oleg Nenashev made changes -
          Status Open [ 1 ] Fixed but Unreleased [ 10203 ]
          Resolution Fixed [ 1 ]
          Released As Role Strategy 2.10

            People

            • Assignee:
              deepansh_nagaria Deepansh Nagaria
              Reporter:
              oleg_nenashev Oleg Nenashev
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: