Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-56447

Git Parameter plugin causes SCM polling to return false negatives

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Component/s: git-parameter-plugin
    • Labels:
      None
    • Environment:
    • Similar Issues:

      Description

      Steps to reproduce:

      1. Initial state is a Jenkins pipeline job, set to "Pipeline script from SCM", with a Jenkinsfile in the root of a Git repo on master.
      2. SCM polling set to 5-minute intervals.
      3. Commits/pushes to master will trigger builds as expected.
      4. Add a Git Parameter:
        1. Name: GIT_BRANCH
        2. Parameter Type: Branch
        3. Default Value: master (note: can also use origin/master or refs/heads/master)
        4. Use repository: (same repo as specified for the Jenkinsfile)
      5. Update the Branch Specifier for the pipeline to ${GIT_BRANCH}
      6. Wait one polling interval.
      7. Push a change to master.
        1. In a few attempts, the first push was detected correctly, and the false negative did not occur until the second push.
        2. In most attempts, the first push was enough to cause the false negative.

      When the false negative occurs, the Git Polling Log correctly shows the Last Built Revision, but does not detect the new HEAD revision.

      Remediating the issue required the following:

      1. Remove the Git Parameter
      2. Set the Branch Spec for the pipeline back to "master"
      3. Start a build manually–this has the effect of resetting/refreshing the polling data
      4. Push a change to master–the next poll should detect the change and build normally

      Running a manual build with the Git Parameter in place, and choosing origin/master from the list, did NOT reset/refresh the polling data, even though the correct hash was checked out for the build.  The false-negative behavior returned on the next poll after another push to master.

      I also upgraded the plugin from version 0.8.0 to version 0.9.9 to see if that would resolve the issue; it did not.

        Attachments

          Activity

          Hide
          jansohn Robin Jansohn added a comment -

          I can confirm this (Jenkins 2.164.3, git-parameter-plugin 0.9.10, git-client-plugin 2.7.7, git-plugin 3.10.0, scm-api-plugin 2.4.1). We also use Bitbucket server (v5.14.4).

          Is this being looked at? With the current state we cannot use Git SCM polling to trigger nightly builds (@midnight). Changes are simply not detected. I looked at the workspace folder and it did not contain the latest changes (no git pull or similar executed).

          Job type is pipeline and we also use the git parameter to specify the branch (default origin/master). As additional behaviors we have Check out to specific local branch with an empty value activated.

          Git Polling Log

          Started on May 24, 2019, 12:49:00 AM
          Using strategy: Default
          [poll] Last Built Revision: Revision 8f72cec4daf37c36fd32884b531f6e9ef64bdff9 (refs/remotes/origin/master)
          using credential git-ssh-creds
           > /usr/bin/git --version # timeout=10
          using GIT_SSH to set credentials SSH key access on Bitbucket server
           > /usr/bin/git ls-remote -h ssh://git@git.my-company.com:7999/project/repo.git # timeout=10
          Found 1 remote heads on ssh://git@git.my-company.com:7999/project/repo.git
          Using strategy: Default
          [poll] Last Built Revision: Revision 8f72cec4daf37c36fd32884b531f6e9ef64bdff9 (refs/remotes/origin/master)
          using credential git-ssh-creds
           > /usr/bin/git --version # timeout=10
          using GIT_SSH to set credentials SSH key access on Bitbucket server
           > /usr/bin/git ls-remote -h ssh://git@git.my-company.com:7999/project/repo.git # timeout=10
          Found 1 remote heads on ssh://git@git.my-company.com:7999/project/repo.git
          Done. Took 0.69 sec
          No changes
          
          Show
          jansohn Robin Jansohn added a comment - I can confirm this (Jenkins 2.164.3, git-parameter-plugin 0.9.10, git-client-plugin 2.7.7, git-plugin 3.10.0, scm-api-plugin 2.4.1). We also use Bitbucket server (v5.14.4). Is this being looked at? With the current state we cannot use Git SCM polling to trigger nightly builds ( @midnight ). Changes are simply not detected. I looked at the workspace folder and it did not contain the latest changes (no git pull or similar executed). Job type is pipeline and we also use the git parameter to specify the branch (default origin/master ). As additional behaviors we have Check out to specific local branch with an empty value activated. Git Polling Log Started on May 24, 2019, 12:49:00 AM Using strategy: Default [poll] Last Built Revision: Revision 8f72cec4daf37c36fd32884b531f6e9ef64bdff9 (refs/remotes/origin/master) using credential git-ssh-creds > /usr/bin/git --version # timeout=10 using GIT_SSH to set credentials SSH key access on Bitbucket server > /usr/bin/git ls-remote -h ssh://git@git.my-company.com:7999/project/repo.git # timeout=10 Found 1 remote heads on ssh://git@git.my-company.com:7999/project/repo.git Using strategy: Default [poll] Last Built Revision: Revision 8f72cec4daf37c36fd32884b531f6e9ef64bdff9 (refs/remotes/origin/master) using credential git-ssh-creds > /usr/bin/git --version # timeout=10 using GIT_SSH to set credentials SSH key access on Bitbucket server > /usr/bin/git ls-remote -h ssh://git@git.my-company.com:7999/project/repo.git # timeout=10 Found 1 remote heads on ssh://git@git.my-company.com:7999/project/repo.git Done. Took 0.69 sec No changes

            People

            • Assignee:
              klimas7 Boguslaw Klimas
              Reporter:
              drosen02 David Rosenfeld
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: