Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-56622

Remove unnecessary JAXB's DatatypeConverter usage

    Details

    • Similar Issues:

      Description

      The plugin is using DatatypeConverter for some hex conversion, it should be replaced by code not coming from JAXB (https://github.com/jenkinsci/scm-api-plugin/blob/d66c700f094576d1d8ab290482d505555d963105/src/test/java/jenkins/scm/impl/mock/MockSCMController.java#L604)
       

      Acceptance criteria

      https://github.com/jenkinsci/scm-api-plugin/search?q=javax.xml.bind&unscoped_q=javax.xml.bind yields nothing anymore

        Attachments

          Issue Links

            Activity

            batmat Baptiste Mathus created issue -
            batmat Baptiste Mathus made changes -
            Field Original Value New Value
            Epic Link JENKINS-55944 [ 197353 ]
            batmat Baptiste Mathus made changes -
            Component/s scm-api-plugin [ 18054 ]
            Component/s pipeline-aws-plugin [ 21921 ]
            batmat Baptiste Mathus made changes -
            Description The plugin is using DatatypeConverter for Base 64 conversion, it could be replaced by {{java.util.Base64}} like was done in [https://github.com/jenkinsci/instance-identity-module/pull/11]
             
            h3. Acceptance criteria

            https://github.com/jenkinsci/pipeline-aws-plugin/search?q=javax.xml.bind&unscoped_q=javax.xml.bind yields nothing anymore
            The plugin is using DatatypeConverter for some hex conversion, it should be replaced by code not coming from JAXB (https://github.com/jenkinsci/scm-api-plugin/blob/d66c700f094576d1d8ab290482d505555d963105/src/test/java/jenkins/scm/impl/mock/MockSCMController.java#L604)
             
            h3. Acceptance criteria

            https://github.com/jenkinsci/scm-api-plugin/search?q=javax.xml.bind&unscoped_q=javax.xml.bind yields nothing anymore
            batmat Baptiste Mathus made changes -
            Priority Major [ 3 ] Minor [ 4 ]
            batmat Baptiste Mathus made changes -
            Assignee Aniket Kadam [ aniketsk ]
            Hide
            batmat Baptiste Mathus added a comment -

            Side note: this is not blocking per se given the usage is in test code. But this would still be better to fix this given we'll need it to get a clean green build on Java 11.

            Show
            batmat Baptiste Mathus added a comment - Side note: this is not blocking per se given the usage is in test code. But this would still be better to fix this given we'll need it to get a clean green build on Java 11.
            batmat Baptiste Mathus made changes -
            Labels newbie-friendly java11 newbie-friendly
            batmat Baptiste Mathus made changes -
            Labels java11 newbie-friendly java11 newbie-friendly triaged
            batmat Baptiste Mathus made changes -
            Assignee Baptiste Mathus [ batmat ]
            batmat Baptiste Mathus made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            batmat Baptiste Mathus made changes -
            Remote Link This issue links to "PR (Web Link)" [ 22517 ]
            batmat Baptiste Mathus made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]

              People

              • Assignee:
                batmat Baptiste Mathus
                Reporter:
                batmat Baptiste Mathus
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: