Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5671

Warnings unit tests: parser matching parts of other parsers input

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: warnings-plugin
    • Labels:
      None
    • Environment:
      Hudson 1.346, Ubuntu Karmic, Warnings 3.2
    • Similar Issues:

      Description

      I am implementing new parsers for gcc errors (see http://issues.jenkins-ci.org/browse/JENKINS-4753), but I stumbled upon a problem to make unit tests succeed.
      The ParserTester base class is checking for each parser that the test input is not matched by any other parser.
      As I am implementing a parser improving message matching reliability for gcc4 output, I left the legacy parser that also handles message of previous versions of gcc. Obviously, no one will ever have to use both parsers in the same build, so it doesn't matter the 2 parser can match part of the test input of the other. Moreover my parser matches part of the output of some other compilers (msbuild, javac).

      Fondamentaly I don't think such a restriction should be imposed on parsers. As the number of parsers will grow, we will inevitably have collisions between parsers. The more variable an input is, the more chances you have that the output of another tool could match its 'grammar'. It doesn't mean a bug. It's just you cannot use these tools together in the same build.

      If we really want to keep having a strong checking against interactions between tools, maybe we should provide a way to declare pairs of incompatible parsers, and do not check these combinations.
      Otherwise, I wonder if there would be a better way to discriminate the output of the tools.

        Attachments

          Activity

          Hide
          drulli Ulli Hafner added a comment -

          That makes sense. The unit test is from the time where all parsers did run (there was no configuration).

          Show
          drulli Ulli Hafner added a comment - That makes sense. The unit test is from the time where all parsers did run (there was no configuration).
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : drulli
          Path:
          trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/WarningsDescriptor.java
          trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/parser/PhpParser.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/AcuCobolParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/AntEclipseParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/AntJavacParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/BuckminsterParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/ErlcParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/FlexSDKParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/GccParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/GnatParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/HpiCompileParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/IarParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/IntelCParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/InvalidsParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/JavaDocParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/JavacParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/MavenParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/MsBuildParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/ParserTester.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/PhpParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/SunCParserTest.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/TiCcsParserTest.java
          http://jenkins-ci.org/commit/29148
          Log:
          [FIXED JENKINS-5671] Removed test that checks if other parsers match for the same warning.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : drulli Path: trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/WarningsDescriptor.java trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/parser/PhpParser.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/AcuCobolParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/AntEclipseParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/AntJavacParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/BuckminsterParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/ErlcParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/FlexSDKParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/GccParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/GnatParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/HpiCompileParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/IarParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/IntelCParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/InvalidsParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/JavaDocParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/JavacParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/MavenParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/MsBuildParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/ParserTester.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/PhpParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/SunCParserTest.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/TiCcsParserTest.java http://jenkins-ci.org/commit/29148 Log: [FIXED JENKINS-5671] Removed test that checks if other parsers match for the same warning.

            People

            • Assignee:
              drulli Ulli Hafner
              Reporter:
              fchateau fchateau
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: