Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5687

Parameterized trigger from multi-configuration project does not trigger

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Labels:
      None
    • Environment:
      Ubuntu Linux 8.10, Sun JDK 1.6.0_14

      Description

      We have a multi-configuration job that builds a bunch of builds with various configurations. After the job completes, we use parameterized trigger plugin to launch a test with the respective configurations. Screenshot of the multi-configuration project is shows in attachment "Picture 2.png"

      The properties file contains 2 lines like this:
      BUILDTOTEST=8015
      CONFIGURATION=FOOBAR

      We upgraded this plugin from version 2.0 to 2.3 and discovered the downstream test job was no longer being triggered. No exceptions in the logs. No explanation in build consoles.

      Downgrade back to 2.0 makes the downstream job triggering again.

      1. patch_BuildTrigger.txt
        1 kB
        Simon Wiest
      1. Picture 2.png
        29 kB

        Activity

        Hide
        kphonik Jason Stiefel added a comment -

        Any thoughts on this? We need to build another project once all our config axes have completed...

        Show
        kphonik Jason Stiefel added a comment - Any thoughts on this? We need to build another project once all our config axes have completed...
        Hide
        swiest Simon Wiest added a comment -

        The current implementation of hudson.plugins.parameterizedtrigger.BuildTrigger does not take into account the special nature of MatrixBuilds. The attached patch (patch-BuildTrigger.txt) will add MatrixBuild support like hudson.tasks.BuildTrigger does.

        Anybody out there who could to review the patch?

        Show
        swiest Simon Wiest added a comment - The current implementation of hudson.plugins.parameterizedtrigger.BuildTrigger does not take into account the special nature of MatrixBuilds. The attached patch (patch-BuildTrigger.txt) will add MatrixBuild support like hudson.tasks.BuildTrigger does. Anybody out there who could to review the patch?
        Hide
        samodelkin samodelkin added a comment -

        The patch looks good to me (I've made similar patch independently, before I found that the issue already exists in hudson issue tracker) and fixes the problem for me.

        Can this patch be committed, please?

        Show
        samodelkin samodelkin added a comment - The patch looks good to me (I've made similar patch independently, before I found that the issue already exists in hudson issue tracker) and fixes the problem for me. Can this patch be committed, please?
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in hudson
        User: : mindless
        Path:
        trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/BuildTrigger.java
        http://jenkins-ci.org/commit/32432
        Log:
        [parameterized-trigger] [FIXED JENKINS-5687] add patch from swiest to add
        support for matrix projects.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/BuildTrigger.java http://jenkins-ci.org/commit/32432 Log: [parameterized-trigger] [FIXED JENKINS-5687] add patch from swiest to add support for matrix projects.
        Hide
        darkfang Darkfang added a comment -

        I've tried building the last version from SVN and load it into hudson 1.361
        The bug is still present. By looking at the proposed patch and the applied ones it seems a part of the patch has been left out:
        -public class BuildTrigger extends Notifier implements DependecyDeclarer {
        +public class BuildTrigger extends Notifier implements DependecyDeclarer, MatrixAggregatable {

        I'm no expert in Java and never had a look at Hudson code but with the applied patch not working, I'd say this bit is important !

        Show
        darkfang Darkfang added a comment - I've tried building the last version from SVN and load it into hudson 1.361 The bug is still present. By looking at the proposed patch and the applied ones it seems a part of the patch has been left out: -public class BuildTrigger extends Notifier implements DependecyDeclarer { +public class BuildTrigger extends Notifier implements DependecyDeclarer, MatrixAggregatable { I'm no expert in Java and never had a look at Hudson code but with the applied patch not working, I'd say this bit is important !
        Hide
        darkfang Darkfang added a comment -

        Note: I've applied the line missing from the patch in SVN repo, recompiled and reloaded it into hudson and it now works perfectly !

        Show
        darkfang Darkfang added a comment - Note: I've applied the line missing from the patch in SVN repo, recompiled and reloaded it into hudson and it now works perfectly !
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in hudson
        User: : mindless
        Path:
        trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/BuildTrigger.java
        http://jenkins-ci.org/commit/33246
        Log:
        JENKINS-5687 oops, missed a line in applying patch (thx Darkfang)

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/BuildTrigger.java http://jenkins-ci.org/commit/33246 Log: JENKINS-5687 oops, missed a line in applying patch (thx Darkfang)

          People

          • Assignee:
            mindless Alan Harder
            Reporter:
            sti Sami Tikka
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: