Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-57602

NPE in Support Core Plugin when reporting agents

    Details

    • Similar Issues:

      Description

      I have a node which has been configured with JCasC and then never connected. When SupportĀ  Core Plugin generates a bundle, I see NPE in System logs.

      Acceptance criteria:

      • There is handling of null inputs in the reporting path

      Nice 2 have:

      • Methods are annotated to ensure that there is no such mistakes happening in the future
      WARNING: Could not attach ''nodes.md'' to support bundle java.lang.NullPointerException at com.cloudbees.jenkins.support.util.Markdown.escapeBacktick(Markdown.java:17) at com.cloudbees.jenkins.support.impl.AboutJenkins$NodesContent.printTo(AboutJenkins.java:877) at com.cloudbees.jenkins.support.api.PrintedContent.writeTo(PrintedContent.java:56) at com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:316) at com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:278) at com.cloudbees.jenkins.support.SupportPlugin$PeriodicWorkImpl.lambda$doRun$0(SupportPlugin.java:820) at java.lang.Thread.run(Thread.java:748)
      

        Attachments

          Issue Links

            Activity

            Hide
            batmat Baptiste Mathus added a comment -

            I think we should check if this also reproducible out of JCasC configured.

            At this stage, Oleg is saying it looks only like log spam, but we'd need to double check.

            Show
            batmat Baptiste Mathus added a comment - I think we should check if this also reproducible out of JCasC configured. At this stage, Oleg is saying it looks only like log spam, but we'd need to double check.
            Show
            mramonleon Ramon Leon added a comment - - edited PR: https://github.com/jenkinsci/support-core-plugin/pull/179
            Hide
            mramonleon Ramon Leon added a comment - - edited

            It only happens with JCasC because the node configured ha the field to null instead of "" (empty string). Not sure whether it's a bug in JCasC or not because the field is mandatory anyway. Why can you leave it empty in the UI?

            If we consider that JCasC should do the same as the UI then it's a bug in the UI.

            Oleg Nenashev WDYT?

            https://github.com/jenkinsci/support-core-plugin/pull/179#issuecomment-510910195

            Show
            mramonleon Ramon Leon added a comment - - edited It only happens with JCasC because the node configured ha the field to null instead of "" (empty string). Not sure whether it's a bug in JCasC or not because the field is mandatory anyway. Why can you leave it empty in the UI? If we consider that JCasC should do the same as the UI then it's a bug in the UI. Oleg Nenashev WDYT? https://github.com/jenkinsci/support-core-plugin/pull/179#issuecomment-510910195

              People

              • Assignee:
                mramonleon Ramon Leon
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: