Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5764

incremental builds leave modules unbuilt upon failure

          Details

          • Type: Bug
          • Status: Resolved
          • Priority: Major
          • Resolution: Fixed
          • Component/s: maven-plugin
          • Labels:
            None

            Description

            We're using maven + hudson + java. I kicked off a build which resulted in a failure in a module. This left several modules unbuilt, even though they did not depend on the failed module. I kicked off a new build, however, the previously unbuilt modules were still not rebuilt. Please let me know if you need more information.

              Issue Links

              depends on

              Bug - A problem which impairs or prevents the functions of the product. JENKINS-9072 Incremental builds: Marking modules not being build early, doesn't work with maven 3 projects

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Resolved
              is duplicated by

              Bug - A problem which impairs or prevents the functions of the product. JENKINS-6976 In incremental build mode - if a breaking commit is done to a module while another module is broken, the build eventually succeeds

              • Major - Major loss of function.
              • Resolved

              Improvement - An improvement or enhancement to an existing feature or task. JENKINS-8350 Incremental builds should include previous builds' modules if they couldn't be executed due to a failure in another module of the previous build

              • Major - Major loss of function.
              • Resolved
              is related to

              Bug - A problem which impairs or prevents the functions of the product. JENKINS-13758 Incremental Builds: If a build is aborted right after a failed one, not all necessary modules are build

              • Major - Major loss of function.
              • Open

              Bug - A problem which impairs or prevents the functions of the product. JENKINS-5121 Deploy all built modules on success, including from previous failed builds

              • Major - Major loss of function.
              • Resolved

              Improvement - An improvement or enhancement to an existing feature or task. JENKINS-5639 Missing modules in deploying to maven repository in Incremental build

              • Major - Major loss of function.
              • Resolved

                Activity

                Ascending order - Click to sort in descending order
                11 older comments
                Hide
                Permalink
                kutzi kutzi added a comment - - edited

                Actually, I wanted to disagree first, but then I thought that you're right. Deploy action might be handled as a special case, but there are possibly many more after-build actions which we don't know about. So just building all the same modules again - plus any with new SCM changes - might be the safest way to handle that.

                But unfortunately it's not easier to implemented that - not least because I've already implemented the other way.

                Show
                kutzi kutzi added a comment - - edited Actually, I wanted to disagree first, but then I thought that you're right. Deploy action might be handled as a special case, but there are possibly many more after-build actions which we don't know about. So just building all the same modules again - plus any with new SCM changes - might be the safest way to handle that. But unfortunately it's not easier to implemented that - not least because I've already implemented the other way.
                Hide
                Permalink
                kutzi kutzi added a comment - - edited

                Closing this again as 'this' bug as per original description is fixed.
                The issue with the deployment of artifacts is JENKINS-5121

                Show
                kutzi kutzi added a comment - - edited Closing this again as 'this' bug as per original description is fixed. The issue with the deployment of artifacts is JENKINS-5121
                Hide
                Permalink
                scm_issue_link SCM/JIRA link daemon added a comment -

                Code changed in jenkins
                User: Christoph Kutzinski
                Path:
                maven-plugin/src/main/java/hudson/maven/MavenBuild.java
                maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java
                maven-plugin/src/main/java/hudson/maven/UnbuiltModuleAction.java
                http://jenkins-ci.org/commit/jenkins/f4233876cdab86c7d19ecf3fcd8f0c530d39117f
                Log:
                [FIXED JENKINS-5764] maven incremental builds leave modules unbuilt
                upon failure

                Show
                scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: maven-plugin/src/main/java/hudson/maven/MavenBuild.java maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java maven-plugin/src/main/java/hudson/maven/UnbuiltModuleAction.java http://jenkins-ci.org/commit/jenkins/f4233876cdab86c7d19ecf3fcd8f0c530d39117f Log: [FIXED JENKINS-5764] maven incremental builds leave modules unbuilt upon failure
                Hide
                Permalink
                scm_issue_link SCM/JIRA link daemon added a comment -

                Code changed in jenkins
                User: Christoph Kutzinski
                Path:
                changelog.html
                http://jenkins-ci.org/commit/jenkins/27871ce1df3cebdcffd3e2992c21c92a8696df75
                Log:
                record changes for JENKINS-5764 and JENKINS-9072

                Show
                scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: changelog.html http://jenkins-ci.org/commit/jenkins/27871ce1df3cebdcffd3e2992c21c92a8696df75 Log: record changes for JENKINS-5764 and JENKINS-9072
                Hide
                Permalink
                scm_issue_link SCM/JIRA link daemon added a comment -

                Code changed in jenkins
                User: Christoph Kutzinski
                Path:
                src/main/java/hudson/maven/MavenBuild.java
                src/main/java/hudson/maven/MavenModuleSetBuild.java
                src/main/java/hudson/maven/UnbuiltModuleAction.java
                http://jenkins-ci.org/commit/maven-plugin/3faaa85e4804cdb7e5462960b036f1fd9276d018
                Log:
                [FIXED JENKINS-5764] maven incremental builds leave modules unbuilt
                upon failure
                Originally-Committed-As: f4233876cdab86c7d19ecf3fcd8f0c530d39117f

                Show
                scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/maven/MavenBuild.java src/main/java/hudson/maven/MavenModuleSetBuild.java src/main/java/hudson/maven/UnbuiltModuleAction.java http://jenkins-ci.org/commit/maven-plugin/3faaa85e4804cdb7e5462960b036f1fd9276d018 Log: [FIXED JENKINS-5764] maven incremental builds leave modules unbuilt upon failure Originally-Committed-As: f4233876cdab86c7d19ecf3fcd8f0c530d39117f

                  People

                  • Assignee:
                    kutzi kutzi
                    Reporter:
                    matthewnewhook matthewnewhook
                  • Votes:
                    2 Vote for this issue
                    Watchers:
                    7 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: