Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-58160

Don't use Guava Beta APIs

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Done
    • Icon: Blocker Blocker
    • ec2-plugin
    • None
    • Amazon EC2 plug-in v1.44.1

      The EC2 plug-in currently uses Guava Beta APIs:

      • hudson.plugins.ec2.EC2HostAddressProvider uses Guava's HostAndPort class, for no clear reason.
      • hudson.plugins.ec2.win.winrm.WindowsProcess uses Guava's Closeables utility methods.

      Using Guava's Beta APIs is strongly discouraged as they can change at any time.

      In fact, this issue is blocking me from finishing JENKINS-56839: Jenkins core provides Guava 11, but a test dependency I am using pulls in Guava 20. While a bit messy, this wouldn't usually be an issue due to Guava's API stability guarantee; however, because the EC2 plug-in is using the above two beta APIs that work differently in Guava 20 than they did in Guava 11, the tests break.

      I propose dropping the use of the above two Guava Beta APIs alltogether.

            Unassigned Unassigned
            acrolinx_blumenbach Tilman Blumenbach
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: