Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5835

Include repository browsing support for Kiln

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: mercurial-plugin
    • Labels:
      None

      Description

      The mercurial hudson plugin should also support repository browsing for Kiln (http://www.fogcreek.com/Kiln/)

      Attached is a svn patch off of 1.25 tag that includes kiln support.

      1. kiln.patch
        4 kB
        timmytonyboots
      2. kiln.test.diff
        1 kB
        timmytonyboots

        Activity

        Hide
        mfriedenhagen Mirko Friedenhagen added a comment -

        Hello Timmy,

        as far as I can see your patch does not include a test, please take a look at those provided for the other browsers.

        Regards
        Mirko

        Show
        mfriedenhagen Mirko Friedenhagen added a comment - Hello Timmy, as far as I can see your patch does not include a test, please take a look at those provided for the other browsers. Regards Mirko
        Hide
        timmytonyboots timmytonyboots added a comment -


        Added a KilnHG unit test.

        Show
        timmytonyboots timmytonyboots added a comment - Added a KilnHG unit test.
        Hide
        mfriedenhagen Mirko Friedenhagen added a comment -

        Hello Timmy,

        the patches look good to me, if you have SVN access I would be glad if you just committed your changes to the trunk and updated http://wiki.jenkins-ci.org/display/JENKINS/Mercurial+Plugin accordingly.

        Best Regards
        Mirko

        Show
        mfriedenhagen Mirko Friedenhagen added a comment - Hello Timmy, the patches look good to me, if you have SVN access I would be glad if you just committed your changes to the trunk and updated http://wiki.jenkins-ci.org/display/JENKINS/Mercurial+Plugin accordingly. Best Regards Mirko
        Hide
        timmytonyboots timmytonyboots added a comment -


        Sorry, I don't have commit privileges.

        Show
        timmytonyboots timmytonyboots added a comment - Sorry, I don't have commit privileges.
        Hide
        mfriedenhagen Mirko Friedenhagen added a comment -

        Fixed with http://fisheye.jenkins-ci.org/changelog/Hudson?cs=29420, should go into version 1.28.

        Show
        mfriedenhagen Mirko Friedenhagen added a comment - Fixed with http://fisheye.jenkins-ci.org/changelog/Hudson?cs=29420 , should go into version 1.28.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in hudson
        User: : mfriedenhagen
        Path:
        trunk/hudson/plugins/mercurial/src/main/java/hudson/plugins/mercurial/browser/KilnHG.java
        trunk/hudson/plugins/mercurial/src/main/resources/hudson/plugins/mercurial/browser/KilnHG/config.jelly
        trunk/hudson/plugins/mercurial/src/main/resources/hudson/plugins/mercurial/browser/KilnHG/help-url.html
        trunk/hudson/plugins/mercurial/src/test/java/hudson/plugins/mercurial/browser/KilnHGTest.java
        http://jenkins-ci.org/commit/29420
        Log:
        [FIXED JENKINS-5835] Include repository browsing support for Kiln (patch by timmytonyboots).

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : mfriedenhagen Path: trunk/hudson/plugins/mercurial/src/main/java/hudson/plugins/mercurial/browser/KilnHG.java trunk/hudson/plugins/mercurial/src/main/resources/hudson/plugins/mercurial/browser/KilnHG/config.jelly trunk/hudson/plugins/mercurial/src/main/resources/hudson/plugins/mercurial/browser/KilnHG/help-url.html trunk/hudson/plugins/mercurial/src/test/java/hudson/plugins/mercurial/browser/KilnHGTest.java http://jenkins-ci.org/commit/29420 Log: [FIXED JENKINS-5835] Include repository browsing support for Kiln (patch by timmytonyboots).
        Hide
        mfriedenhagen Mirko Friedenhagen added a comment -

        Version 1.28 is released.

        Show
        mfriedenhagen Mirko Friedenhagen added a comment - Version 1.28 is released.

          People

          • Assignee:
            mfriedenhagen Mirko Friedenhagen
            Reporter:
            timmytonyboots timmytonyboots
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: