Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-58686

Syncing to revision 0 runs an invalid command

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: p4-plugin
    • Labels:
      None
    • Environment:
      Jenkins 2.164.3
      P4 plugin 1.10.3
    • Similar Issues:

      Description

      Found this in our logs for a pipeline that syncs its p4 workspace to CL 0:

       

      p4 changes -m1 -ssubmitted //WORKSPACE_NAME/...@1,0
      P4: no revisions under //WORKSPACE_NAME/...@1,0 using change: 0
      

      This seems to be okay and not cause problems most of the time.  But occasionally we get:

      p4 changes -m1 -ssubmitted //WORKSPACE_NAME/...@1,0
      Too many rows scanned (over 300000000); see 'p4 help maxscanrows'.

      Which does cause the sync to fail.  It looks to me like this is related to these recent changes: https://swarm.workshop.perforce.com/changes/25826

        Attachments

          Activity

          Hide
          wbrode William Brode added a comment -

          I've created a pull request with a potential fix: https://github.com/jenkinsci/p4-plugin/pull/103

          Show
          wbrode William Brode added a comment - I've created a pull request with a potential fix:  https://github.com/jenkinsci/p4-plugin/pull/103
          Hide
          p4karl Karl Wirth added a comment -

          Hi William Brode, Thanks for reporting this and providing a fix. As background, how is the job configured to sync to '0'?

          Is this an explicit sync such as pin to changelist '0' or Groovy code that syncs to '0'? If it is then can you please explain how it's setup.

          Or is this just a side effect of normal operation? If it is then can you please send me a bigger section of console log.

          Thanks in advance,

          Karl

          Show
          p4karl Karl Wirth added a comment - Hi William Brode , Thanks for reporting this and providing a fix. As background, how is the job configured to sync to '0'? Is this an explicit sync such as pin to changelist '0' or Groovy code that syncs to '0'? If it is then can you please explain how it's setup. Or is this just a side effect of normal operation? If it is then can you please send me a bigger section of console log. Thanks in advance, Karl
          Show
          wbrode William Brode added a comment - Merged to master:  https://github.com/jenkinsci/p4-plugin/commit/8fbc3eb72220d3b0cc4091150152c0f5ff70b8a9
          Hide
          wbrode William Brode added a comment -

          Karl Wirth - the pipeline is configured to take a Changelist as an input parameter.  The Changelist parameter is defaulted to 0 and we don't really change it.  That parameter is used with a syncOnly populate option for the pin setting: 

          pin: '${Changelist}'

           

          So we are essentially just pinning it to 0.  This is done to ensure no files are synced.

          Show
          wbrode William Brode added a comment - Karl Wirth - the pipeline is configured to take a Changelist as an input parameter.  The Changelist parameter is defaulted to 0 and we don't really change it.  That parameter is used with a syncOnly populate option for the pin setting:  pin: '${Changelist}'   So we are essentially just pinning it to 0.  This is done to ensure no files are synced.
          Hide
          p4karl Karl Wirth added a comment -

          Hi William Brode - Thanks.  Paul has already pulled in the code but I wanted to pass on the background to our QA team.

           

           

          Show
          p4karl Karl Wirth added a comment - Hi William Brode - Thanks.  Paul has already pulled in the code but I wanted to pass on the background to our QA team.    
          Hide
          p4paul Paul Allen added a comment -

          Released in 1.10.4

          Show
          p4paul Paul Allen added a comment - Released in 1.10.4

            People

            • Assignee:
              wbrode William Brode
              Reporter:
              wbrode William Brode
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: