Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-59150

Jenkins LTS 2.176.x logs about the new Stapler routing rules have erroneous information

    Details

    • Similar Issues:

      Description

      After upgrading to Jenkins LTS 2.176, the Server Status page in Gerrit Trigger section didn't display any information, showing a "Data error" message.

      Logs:

      2019-08-30 09:47:15.644+0000 [id=65732] WARNING j.s.s.StaplerFilteredActionListener#onGetterTrigger: New Stapler routing rules result in the URL "/gerrit-trigger/serverStatuses" no longer being allowed. If you consider it safe to use, add the following to the whitelist: "method com.sonyericsson.hudson.plugins.gerrit.trigger.GerritManagement getServerStatuses". Learn more: https://jenkins.io/redirect/stapler-routing

      The line 

      method com.sonyericsson.hudson.plugins.gerrit.trigger.GerritManagement getServerStatuses

      is wrong, because it doesn't work upon testing. Instead, the correct line to be added to the whitelist is 

      com.sonyericsson.hudson.plugins.gerrit.trigger.GerritManagement serverStatuses

      as per 

      https://jenkins.io/doc/upgrade-guide/2.176/#upgrading-to-jenkins-lts-2-176-x

       

      If one doesn't have enough Jenkins / debugging experience, an error like this can become very hard to track down and fix.

        Attachments

          Activity

          Hide
          danielbeck Daniel Beck added a comment -

          Don't use a gerrit-trigger version that has been obsolete since February.

          Show
          danielbeck Daniel Beck added a comment - Don't use a gerrit-trigger version that has been obsolete since February.
          Hide
          danielbeck Daniel Beck added a comment -

          And regarding the reported problem here, there isn't one either.

          The complete log messages read:

          Sep 04, 2019 1:27:20 PM WARNING jenkins.security.stapler.StaplerFilteredActionListener onDispatchTrigger
          New Stapler dispatch rules result in the URL "/gerrit-trigger/serverStatuses" no longer being allowed. If you consider it safe to use, add the following to the whitelist: "com.sonyericsson.hudson.plugins.gerrit.trigger.GerritManagement serverStatuses". Learn more: https://jenkins.io/redirect/stapler-facet-restrictions
          Sep 04, 2019 1:27:20 PM WARNING jenkins.security.stapler.StaplerFilteredActionListener onGetterTrigger
          New Stapler routing rules result in the URL "/gerrit-trigger/serverStatuses" no longer being allowed. If you consider it safe to use, add the following to the whitelist: "method com.sonyericsson.hudson.plugins.gerrit.trigger.GerritManagement getServerStatuses". Learn more: https://jenkins.io/redirect/stapler-routing

          These are two different messages, for two different potential ways the request could be routed:

          The warnings are logged in the order they are attempted, first the view, then the getter. Everything here works as intended.

          Show
          danielbeck Daniel Beck added a comment - And regarding the reported problem here, there isn't one either. The complete log messages read: Sep 04, 2019 1:27:20 PM WARNING jenkins.security.stapler.StaplerFilteredActionListener onDispatchTrigger New Stapler dispatch rules result in the URL "/gerrit-trigger/serverStatuses" no longer being allowed. If you consider it safe to use, add the following to the whitelist: "com.sonyericsson.hudson.plugins.gerrit.trigger.GerritManagement serverStatuses". Learn more: https://jenkins.io/redirect/stapler-facet-restrictions Sep 04, 2019 1:27:20 PM WARNING jenkins.security.stapler.StaplerFilteredActionListener onGetterTrigger New Stapler routing rules result in the URL "/gerrit-trigger/serverStatuses" no longer being allowed. If you consider it safe to use, add the following to the whitelist: "method com.sonyericsson.hudson.plugins.gerrit.trigger.GerritManagement getServerStatuses". Learn more: https://jenkins.io/redirect/stapler-routing These are two different messages, for two different potential ways the request could be routed: https://github.com/jenkinsci/gerrit-trigger-plugin/blob/master/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritManagement/serverStatuses.jelly (affected by change in 2.176.x) https://github.com/jenkinsci/gerrit-trigger-plugin/blob/771cbf10a95b88921b7ea6d658b9849afaee5f19/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritManagement.java#L231 (affected by change in 2.138.x) The warnings are logged in the order they are attempted, first the view, then the getter. Everything here works as intended.

            People

            • Assignee:
              rsandell rsandell
              Reporter:
              gcimpoies George Cimpoies
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: