Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-59207

READONLY autoclean sync fails on reconcile

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Component/s: p4-plugin
    • Labels:
      None
    • Environment:
      Jenkins ver. 2.150.2
      Plugin ver. 1.10.3
    • Similar Issues:

      Description

      When a READONLY client is synced with the "Auto cleanup and sync" option, the reconcile throws an innocuous "Client of type 'readonly' cannot modify files." error. In 1.10, this error is ignored. In 1.10.3, this error causes the build to fail.

      This may be a consequence of a modification to src/main/java/org/jenkinsci/plugins/p4/client/ClientHelper.java in Change 25759, which added an exception when a reconcile fails. Unfortunately, in the above scenario, reconcile shouldn't even be called, so the fact that it fails should be ignored.

        Attachments

          Activity

          Hide
          douglasawh Doug Whitfield added a comment -

          Issue introduced in 1.10.1, so does seem like 25759 is likely

          Show
          douglasawh Doug Whitfield added a comment - Issue introduced in 1.10.1, so does seem like 25759 is likely
          Hide
          joel_brown Joel Brown added a comment -

          The fact the reconcile failure was ignored in an earlier release is a bug - the error should have been surfaced.   IMO, we fixed it the change you noted.  

          auto cleanup and sync should run "reconcile -w -f" to make the workspace consistent with the last sync.   

          Show
          joel_brown Joel Brown added a comment - The fact the reconcile failure was ignored in an earlier release is a bug - the error should have been surfaced.   IMO, we fixed it the change you noted.   auto cleanup and sync should run "reconcile -w -f" to make the workspace consistent with the last sync.   

            People

            • Assignee:
              Unassigned
              Reporter:
              feelingmimsy Dave Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: