Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5931

Restrict IRC bot commands to specific users

    Details

    • Type: New Feature
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: ircbot-plugin
    • Labels:
      None
    • Environment:
      Hudson 1.350
    • Similar Issues:

      Description

      The IRC plugin provides a IRC bot so that users in the channel can trigger actions in Hudson. This is a nice feature, but currently there is no way to restrict the usage of these commands to a specific group of users. So any user in the channel can trigger jobs, stop them, etc.

      It would be nice if the plugin allowed specifying nicknames which have access to use these commands. The bot could ignore the rest of requests. And ideally it should check if the user is identified to services.

        Attachments

          Issue Links

            Activity

            Hide
            kutzi kutzi added a comment -

            Reasonable request, but sounds a little bit like overkill to me. Next someone requests to allow some commands for some users and some other commands for some other users.
            What about a dedicated chatroom for privileged users? Would that suffice for you?

            Anyway, I wouldn't implement this anytime soon - mainly because I don't use the IRC plugin myself, so I don't have any motivation to.
            So, if you want this feature, the best way for you would be to create a patch.

            Show
            kutzi kutzi added a comment - Reasonable request, but sounds a little bit like overkill to me. Next someone requests to allow some commands for some users and some other commands for some other users. What about a dedicated chatroom for privileged users? Would that suffice for you? Anyway, I wouldn't implement this anytime soon - mainly because I don't use the IRC plugin myself, so I don't have any motivation to. So, if you want this feature, the best way for you would be to create a patch.
            Hide
            jpabloae jpabloae added a comment -

            What about a dedicated chatroom for privileged users? Would that suffice for you?

            Yes, I think it's a reasonable approach.

            So, if you want this feature, the best way for you would be to create a patch.

            Fair enough, I'll see what I can do.

            Thanks!

            Show
            jpabloae jpabloae added a comment - What about a dedicated chatroom for privileged users? Would that suffice for you? Yes, I think it's a reasonable approach. So, if you want this feature, the best way for you would be to create a patch. Fair enough, I'll see what I can do. Thanks!
            Hide
            kutzi kutzi added a comment -

            Please note that because of JENKINS-11606 you can disable commands for a chatroom altogether.
            Maybe that is already enough for your use case.

            Show
            kutzi kutzi added a comment - Please note that because of JENKINS-11606 you can disable commands for a chatroom altogether. Maybe that is already enough for your use case.
            Hide
            jpabloae jpabloae added a comment -

            Nice! This definitely solves the problem in my case.

            Thank you.

            Show
            jpabloae jpabloae added a comment - Nice! This definitely solves the problem in my case. Thank you.
            Hide
            askeing Askeing added a comment - - edited

            Today I found there still have some problems.
            If we send "/msg irc-bot irc-bot: help" to ircbot, the ircbot will allow the command.
            The "Command prefix" setting doesn't work in these case.

            Jenkins ver. 1.480.3
            IRC Plugin ver. 2.22

            Show
            askeing Askeing added a comment - - edited Today I found there still have some problems. If we send "/msg irc-bot irc-bot: help" to ircbot, the ircbot will allow the command. The "Command prefix" setting doesn't work in these case. Jenkins ver. 1.480.3 IRC Plugin ver. 2.22
            Hide
            sag47 Sam Gleske added a comment -

            Why was this marked as resolved? There were no patches or fixes implemented for this. This should have been filed as Closed and WontFix. I say that because it got my hopes up . I'd like to restrict bot query commands to a specific set of users. It doesn't make sense to have an IRC bot that accepts commands from just anybody. It's IRC and not typically a trusted network.

            Show
            sag47 Sam Gleske added a comment - Why was this marked as resolved? There were no patches or fixes implemented for this. This should have been filed as Closed and WontFix. I say that because it got my hopes up . I'd like to restrict bot query commands to a specific set of users. It doesn't make sense to have an IRC bot that accepts commands from just anybody. It's IRC and not typically a trusted network.

              People

              • Assignee:
                Unassigned
                Reporter:
                jpabloae jpabloae
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: