Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-6074

Option to set value for "LineEnd" in clients managed by plugin

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      We have a mixed environment (with Windows and Linux) where builds run from the same (networked) workspace on different platforms.
      This works best if the Perforce clientspecs/workspaces have "LineEnd: share" instead of the default "local", which we manage ourselves by changing the clientspec and resyncing the files (takes double the time).
      I suggest to add an option in the plugin configuration to set the LineEnd value, much like the way we can set "Options".

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : rpetti
          Path:
          trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java
          trunk/hudson/plugins/perforce/src/main/resources/hudson/plugins/perforce/PerforceSCM/config.jelly
          trunk/hudson/plugins/perforce/src/main/webapp/help/lineEnd.html
          http://jenkins-ci.org/commit/29257
          Log:
          [FIXED JENKINS-6074] adding option to select the line endings used by the client spec

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : rpetti Path: trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java trunk/hudson/plugins/perforce/src/main/resources/hudson/plugins/perforce/PerforceSCM/config.jelly trunk/hudson/plugins/perforce/src/main/webapp/help/lineEnd.html http://jenkins-ci.org/commit/29257 Log: [FIXED JENKINS-6074] adding option to select the line endings used by the client spec
          Hide
          emmulator emmulator added a comment -

          After upgrading to version 1.0.27, some Jobs started failing with the following error in the console. Looks like maybe a default value needs to be set for the new property? I'm not sure why some jobs seem to be sensitive to this and not others.

          com.tek42.perforce.PerforceException: Error in client specification. Error detected at line 8. Value for field 'LineEnd' must be one of local/unix/mac/win/share.
          For Command: p4 -s client -i
          With Data:
          ===================
          Client: hudson-main-member-e2e-462822102
          Owner: build.automation
          Host: build107.sbo.cj.com
          Description: Created by build.automation.
          Root: /home/cruise/hudson/workspace/main-member-e2e
          Options: noallwrite clobber nocompress unlocked nomodtime rmdir
          SubmitOptions: submitunchanged
          LineEnd: null
          View:
          //cj/cjo/main/... //hudson-main-member-e2e-462822102/...

          ===================

          at com.tek42.perforce.parse.AbstractPerforceTemplate.saveToPerforce(AbstractPerforceTemplate.java:248)
          at com.tek42.perforce.parse.Workspaces.saveWorkspace(Workspaces.java:68)
          at hudson.plugins.perforce.PerforceSCM.saveWorkspaceIfDirty(PerforceSCM.java:964)
          at hudson.plugins.perforce.PerforceSCM.checkout(PerforceSCM.java:423)
          at hudson.model.AbstractProject.checkout(AbstractProject.java:1040)
          at hudson.model.AbstractBuild$AbstractRunner.checkout(AbstractBuild.java:479)
          at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:411)
          at hudson.model.Run.run(Run.java:1243)
          at hudson.matrix.MatrixBuild.run(MatrixBuild.java:149)
          at hudson.model.ResourceController.execute(ResourceController.java:88)
          at hudson.model.Executor.run(Executor.java:122)
          at hudson.model.OneOffExecutor.run(OneOffExecutor.java:60)
          Finished: FAILURE

          Show
          emmulator emmulator added a comment - After upgrading to version 1.0.27, some Jobs started failing with the following error in the console. Looks like maybe a default value needs to be set for the new property? I'm not sure why some jobs seem to be sensitive to this and not others. com.tek42.perforce.PerforceException: Error in client specification. Error detected at line 8. Value for field 'LineEnd' must be one of local/unix/mac/win/share. For Command: p4 -s client -i With Data: =================== Client: hudson-main-member-e2e-462822102 Owner: build.automation Host: build107.sbo.cj.com Description: Created by build.automation. Root: /home/cruise/hudson/workspace/main-member-e2e Options: noallwrite clobber nocompress unlocked nomodtime rmdir SubmitOptions: submitunchanged LineEnd: null View: //cj/cjo/main/... //hudson-main-member-e2e-462822102/... =================== at com.tek42.perforce.parse.AbstractPerforceTemplate.saveToPerforce(AbstractPerforceTemplate.java:248) at com.tek42.perforce.parse.Workspaces.saveWorkspace(Workspaces.java:68) at hudson.plugins.perforce.PerforceSCM.saveWorkspaceIfDirty(PerforceSCM.java:964) at hudson.plugins.perforce.PerforceSCM.checkout(PerforceSCM.java:423) at hudson.model.AbstractProject.checkout(AbstractProject.java:1040) at hudson.model.AbstractBuild$AbstractRunner.checkout(AbstractBuild.java:479) at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:411) at hudson.model.Run.run(Run.java:1243) at hudson.matrix.MatrixBuild.run(MatrixBuild.java:149) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:122) at hudson.model.OneOffExecutor.run(OneOffExecutor.java:60) Finished: FAILURE
          Hide
          torbent torbent added a comment -

          As also reported, and fixed, in JENKINS-6173.
          Re-closing.

          Show
          torbent torbent added a comment - As also reported, and fixed, in JENKINS-6173 . Re-closing.

            People

            • Assignee:
              rpetti Rob Petti
              Reporter:
              torbent torbent
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: