Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-6167

JNLP slave should support a connection via HTTP proxy

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: In Progress (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      It's possible to use the standard HTTP proxy to bridge arbitrary TCP/IP connection — the CONNECT command.

      JNLP slaves should support this.

        Attachments

        1. 0001-Fix-slave-to-work-behind-http-proxy.patch
          7 kB
          Hiroshi Shirosaki
        2. GWKAXYVK.txt
          2 kB
          Mark Walling

          Activity

          Hide
          mwalling Mark Walling added a comment -

          This patch shows how to do it by hard coding my proxy settings... hopefully this solves half the problem (the other half being how to not hard code my settings)

          Show
          mwalling Mark Walling added a comment - This patch shows how to do it by hard coding my proxy settings... hopefully this solves half the problem (the other half being how to not hard code my settings)
          Hide
          shirosaki Hiroshi Shirosaki added a comment -

          Slave behind http proxy works with this patch.
          Use http_proxy environment variable.

          Show
          shirosaki Hiroshi Shirosaki added a comment - Slave behind http proxy works with this patch. Use http_proxy environment variable.
          Hide
          danielbeck Daniel Beck added a comment -

          Hiroshi Shirosaki: Please submit patches as pull requests on GitHub.

          Show
          danielbeck Daniel Beck added a comment - Hiroshi Shirosaki : Please submit patches as pull requests on GitHub.
          Hide
          shirosaki Hiroshi Shirosaki added a comment -

          I've submitted a patch on GitHub.
          https://github.com/jenkinsci/remoting/pull/27

          Show
          shirosaki Hiroshi Shirosaki added a comment - I've submitted a patch on GitHub. https://github.com/jenkinsci/remoting/pull/27
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Hiroshi Shirosaki
          Path:
          src/main/java/hudson/remoting/Engine.java
          src/main/java/hudson/remoting/Launcher.java
          src/main/java/hudson/remoting/Util.java
          http://jenkins-ci.org/commit/remoting/8c875cbc81d22df898a57ef86e833b41c50470cb
          Log:
          JENKINS-6167 Support JNLP slave connection via HTTP proxy

          We get proxy setting from http.proxyHost property or http_proxy
          environment variable.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Hiroshi Shirosaki Path: src/main/java/hudson/remoting/Engine.java src/main/java/hudson/remoting/Launcher.java src/main/java/hudson/remoting/Util.java http://jenkins-ci.org/commit/remoting/8c875cbc81d22df898a57ef86e833b41c50470cb Log: JENKINS-6167 Support JNLP slave connection via HTTP proxy We get proxy setting from http.proxyHost property or http_proxy environment variable.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/pom.xml
          pom.xml
          http://jenkins-ci.org/commit/jenkins/72e0b9c53a15306e0a7b7117100f4d1b7ec250b8
          Log:
          [FIXED JENKINS-6167 JENKINS-21251 JENKINS-21160]

          Integrated a newer version of remoting & args4j

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/pom.xml pom.xml http://jenkins-ci.org/commit/jenkins/72e0b9c53a15306e0a7b7117100f4d1b7ec250b8 Log: [FIXED JENKINS-6167 JENKINS-21251 JENKINS-21160] Integrated a newer version of remoting & args4j
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: changelog.html http://jenkins-ci.org/commit/jenkins/46dc6850edb1d7ef52592794b15e69db7dfbed1a Log: Noting merges JENKINS-15355 JENKINS-21618 JENKINS-22941 JENKINS-25938 JENKINS-26391 JENKINS-26900 JENKINS-27476 JENKINS-27563 JENKINS-27564 JENKINS-27565 JENKINS-27566 Fixing link text for JENKINS-6167
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/hudson/remoting/Engine.java
          src/main/java/hudson/remoting/Util.java
          http://jenkins-ci.org/commit/remoting/fbb9aff7cf0f9acbba6e97c923efd640b5537c90
          Log:
          JENKINS-31256 Use credentials in waitForServerToBack (#87)

          • JENKINS-31256 Use credentials in waitForServerToBack
            This address three regressions introduced with HUDSON-4071, 662b0f and JENKINS-6167 as these only modified run() resulting in no proxy and no authorization support in waitForServerToBack()
          • Move authorization code to openURLConnection()
          • Factored out sslSocketFactory creation and use sslSocketFactory also in waitForServerToBack()
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/remoting/Engine.java src/main/java/hudson/remoting/Util.java http://jenkins-ci.org/commit/remoting/fbb9aff7cf0f9acbba6e97c923efd640b5537c90 Log: JENKINS-31256 Use credentials in waitForServerToBack (#87) JENKINS-31256 Use credentials in waitForServerToBack This address three regressions introduced with HUDSON-4071, 662b0f and JENKINS-6167 as these only modified run() resulting in no proxy and no authorization support in waitForServerToBack() Move authorization code to openURLConnection() Factored out sslSocketFactory creation and use sslSocketFactory also in waitForServerToBack()

            People

            • Assignee:
              shirosaki Hiroshi Shirosaki
              Reporter:
              kohsuke Kohsuke Kawaguchi
            • Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated: