Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-61692

"HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Environment:
      Jenkins ver. 2.222.1
      just plain Jenkins
      no plugins
      user is an active directory user
    • Similar Issues:
    • Released As:
      Jenkins 2.229

      Description

      today I have test to deployed the latest LTS version: Jenkins ver. 2.222.1

      as I want to configure my proxy it crashs directly on "Validate Proxy"

      proxy.xml is different between v 2.222.1 and 2.204.5

      user is an AD user, have already try:

      user@domain.tld
      domain\user
      user
      => same behavior

      before that new LTS version I use Jenkins ver. 2.204.5 were this working fine

       

      java.lang.NullPointerException
      	at hudson.util.Secret$1.convert(Secret.java:306)
      	at hudson.util.Secret$1.convert(Secret.java:304)
      	at org.kohsuke.stapler.AnnotationHandler.convert(AnnotationHandler.java:66)
      	at org.kohsuke.stapler.QueryParameter$HandlerImpl.parse(QueryParameter.java:74)
      	at org.kohsuke.stapler.QueryParameter$HandlerImpl.parse(QueryParameter.java:62)
      	at org.kohsuke.stapler.AnnotationHandler.handle(AnnotationHandler.java:91)
      	at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:204)
      	at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:145)
      	at org.kohsuke.stapler.MetaClass$11.doDispatch(MetaClass.java:535)
      	at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)
      	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:747)
      	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:878)
      	at org.kohsuke.stapler.MetaClass$4.doDispatch(MetaClass.java:280)
      	at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)
      	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:747)
      	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:878)
      	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:676)
      	at org.kohsuke.stapler.Stapler.service(Stapler.java:238)
      	at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
      	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:755)
      	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1617)
      	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:154)
      	at jenkins.security.ResourceDomainFilter.doFilter(ResourceDomainFilter.java:76)
      	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:151)
      	at jenkins.telemetry.impl.UserLanguages$AcceptLanguageFilter.doFilter(UserLanguages.java:128)
      	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:151)
      	at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:157)
      	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
      	at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:153)
      	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
      	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84)
      	at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51)
      	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
      	at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:118)
      	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
      	at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
      	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
      	at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142)
      	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
      	at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271)
      	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
      	at jenkins.security.BasicHeaderProcessor.doFilter(BasicHeaderProcessor.java:93)
      	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
      	at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249)
      	at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67)
      	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
      	at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:90)
      	at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:171)
      	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
      	at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:49)
      	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
      	at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:82)
      	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
      	at org.kohsuke.stapler.DiagnosticThreadNameFilter.doFilter(DiagnosticThreadNameFilter.java:30)
      	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
      	at jenkins.security.SuspiciousRequestFilter.doFilter(SuspiciousRequestFilter.java:36)
      	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
      	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:545)
      	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
      	at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:566)
      	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
      	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
      	at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1610)
      	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
      	at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1300)
      	at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
      	at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:485)
      	at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1580)
      	at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
      	at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1215)
      	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
      	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
      	at org.eclipse.jetty.server.Server.handle(Server.java:500)
      	at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:383)
      	at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:547)
      	at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:375)
      	at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:273)
      	at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
      	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:103)
      	at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:117)
      	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336)
      	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313)
      	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171)
      	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:129)
      	at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:375)
      	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806)
      	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:938)
      	at java.lang.Thread.run(Unknown Source)
      

        Attachments

        1. diff of proxy.xml.png
          diff of proxy.xml.png
          41 kB
        2. screenshot-1.png
          screenshot-1.png
          557 kB
        3. screenshot-2.png
          screenshot-2.png
          118 kB
        4. screenshot-3.png
          screenshot-3.png
          357 kB
        5. screenshot-4.png
          screenshot-4.png
          260 kB
        6. screenshot-5.png
          screenshot-5.png
          64 kB
        7. screenshot-6.png
          screenshot-6.png
          290 kB
        8. screenshot-7.png
          screenshot-7.png
          325 kB

          Issue Links

            Activity

            Hide
            danielbeck Daniel Beck added a comment -

            Looks like a regression in 2.205:

            secretPassword gets set: https://github.com/jenkinsci/jenkins/blob/489e4b3bcb8aeb06c962e793fc5ddca0649b6de4/core/src/main/resources/hudson/ProxyConfiguration/config.groovy#L15

            Form validation uses password which doesn't exist: https://github.com/jenkinsci/jenkins/blob/489e4b3bcb8aeb06c962e793fc5ddca0649b6de4/core/src/main/resources/hudson/ProxyConfiguration/config.groovy#L25


            Thomas Patzig Could you clarify whether this affects only form validation ("Validate Proxy") or whether saving the password doesn't work either?

            Show
            danielbeck Daniel Beck added a comment - Looks like a regression in 2.205: secretPassword gets set: https://github.com/jenkinsci/jenkins/blob/489e4b3bcb8aeb06c962e793fc5ddca0649b6de4/core/src/main/resources/hudson/ProxyConfiguration/config.groovy#L15 Form validation uses password which doesn't exist: https://github.com/jenkinsci/jenkins/blob/489e4b3bcb8aeb06c962e793fc5ddca0649b6de4/core/src/main/resources/hudson/ProxyConfiguration/config.groovy#L25 Thomas Patzig Could you clarify whether this affects only form validation ("Validate Proxy") or whether saving the password doesn't work either?
            Hide
            thomaspatzig Thomas Patzig added a comment -

            ..can't access the links....

             

            ...but AFAIK it is only on validation. "submit" works... 

             

            but then the other issue happens: proxy doesn't work with git...  https://issues.jenkins-ci.org/browse/JENKINS-61693

            Show
            thomaspatzig Thomas Patzig added a comment - ..can't access the links....   ...but AFAIK it is only on validation. "submit" works...    but then the other issue happens: proxy doesn't work with git...   https://issues.jenkins-ci.org/browse/JENKINS-61693
            Hide
            danielbeck Daniel Beck added a comment -

            ...but AFAIK it is only on validation. "submit" works...

            Thanks for the clarification.

            Show
            danielbeck Daniel Beck added a comment - ...but AFAIK it is only on validation. "submit" works... Thanks for the clarification.
            Hide
            thomaspatzig Thomas Patzig added a comment -

            ..have try jenkins.war from PR 4607.... it works...

             

            have also found a mistake on my side....

            I automize the Jenkins installation and bootstrap config to check latest versions... for that I do some http posts like the user would do...

             

            for setup the proxy I have use "post descriptorByName/hudson.ProxyConfiguration/validateProxy" with body form url encoded content and the content "password" instead of "secretPassword"...

            (same on http post pluginManager/proxyConfigure)

             

            I think "password" is no longer supported in that post. Am I right? (..and that were the Links before)

             

            ....with fix on my side ("secretPassword" instead of "password") it works fine.

            Show
            thomaspatzig Thomas Patzig added a comment - ..have try jenkins.war from PR 4607.... it works...   have also found a mistake on my side.... I automize the Jenkins installation and bootstrap config to check latest versions... for that I do some http posts like the user would do...   for setup the proxy I have use "post descriptorByName/hudson.ProxyConfiguration/validateProxy" with body form url encoded content and the content "password" instead of "secretPassword"... (same on http post pluginManager/proxyConfigure)   I think "password" is no longer supported in that post. Am I right? (..and that were the Links before)   ....with fix on my side ("secretPassword" instead of "password") it works fine.
            Hide
            danielbeck Daniel Beck added a comment -

            I think "password" is no longer supported in that post. Am I right? (..and that were the Links before)

            ....with fix on my side ("secretPassword" instead of "password") it works fine.

            That's correct; you're effectively saving the configuration without password when using the obsolete name.

            Show
            danielbeck Daniel Beck added a comment - I think "password" is no longer supported in that post. Am I right? (..and that were the Links before) ....with fix on my side ("secretPassword" instead of "password") it works fine. That's correct; you're effectively saving the configuration without password when using the obsolete name.

              People

              • Assignee:
                danielbeck Daniel Beck
                Reporter:
                thomaspatzig Thomas Patzig
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: