Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-6173

Value for "LineEnd" field defaults to "null"

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Blocker
    • Resolution: Fixed
    • Component/s: perforce-plugin
    • Labels:
      None
    • Environment:
      Hudson 1.353, Perforce plugin 1.0.27
    • Similar Issues:

      Description

      The option to specify LineEnd was added to 1.0.27 as a response to JENKINS-6074.
      When I upgraded the plugin and started Hudson, I immediately got a number of build errors because the plugin set the value for LineEnd to the string "null", which Perforce itself wouldn't accept.
      I've downgraded to 1.0.26.
      I suggest that the default, if LineEnd is not present in the configuration, should be either:

      • Don't specify LineEnd in the client spec and let Perforce default it
      • Default to "local", which is the Perforce default, AFAIK

        Attachments

          Activity

          Hide
          rpetti Rob Petti added a comment -

          Odd. The default is already set to local...

          I'll add code that checks for a valid value before passing it into the view.

          Show
          rpetti Rob Petti added a comment - Odd. The default is already set to local... I'll add code that checks for a valid value before passing it into the view.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : rpetti
          Path:
          trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java
          http://jenkins-ci.org/commit/29817
          Log:
          [FIXED JENKINS-6173] adding a check to make sure that the lineend option is a valid value before putting it into the client spec

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : rpetti Path: trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java http://jenkins-ci.org/commit/29817 Log: [FIXED JENKINS-6173] adding a check to make sure that the lineend option is a valid value before putting it into the client spec
          Hide
          torbent torbent added a comment -

          I hadn't actually configured any jobs to specify LineEnd, and thus there was no line-ending setting in the config.xml files. That's the only clues I can give, sorry ...

          Show
          torbent torbent added a comment - I hadn't actually configured any jobs to specify LineEnd, and thus there was no line-ending setting in the config.xml files. That's the only clues I can give, sorry ...
          Hide
          torbent torbent added a comment -

          Another user reported the same as a note in JENKINS-6074.

          Show
          torbent torbent added a comment - Another user reported the same as a note in JENKINS-6074 .
          Hide
          torbent torbent added a comment -

          Upgraded to 1.0.28, and the builds run fine with no explicit configuration of LineEnd.
          Closing.

          Show
          torbent torbent added a comment - Upgraded to 1.0.28, and the builds run fine with no explicit configuration of LineEnd. Closing.

            People

            • Assignee:
              Unassigned
              Reporter:
              torbent torbent
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: