Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62116

Organization Scan recreates hooks for all repository

    Details

    • Similar Issues:

      Description

      The organization scan recreates a hook for all repositories for which there is an item. We can see that the WebHook of each repository is recreated:

      Apr 30, 2020 12:42:08 AM FINE com.cloudbees.jenkins.GitHubWebHook$1 apply
      Calling registerHooks() for dse-team-apac/aburdajewicz/testOrg/public-repo
      Apr 30, 2020 12:42:08 AM INFO org.jenkinsci.plugins.github.webhook.WebhookManager$1 run
      GitHub webhooks activated for job dse-team-apac/aburdajewicz/testOrg/public-repo with [GitHubRepositoryName[host=github.example.com,username=test-org,repository=public-repo]] (events: [PULL_REQUEST, PUSH])
      Apr 30, 2020 12:42:09 AM FINE org.jenkinsci.plugins.github.webhook.WebhookManager$3 applyNullSafe
      Replaced hook https://github.example.com/api/v3/repos/test-org/public-repo/hooks/32392 (events: [PULL_REQUEST, PUSH, REPOSITORY])
      Apr 30, 2020 12:42:09 AM FINE org.jenkinsci.plugins.github.webhook.WebhookManager$3 applyNullSafe
      Created hook https://github.example.com/api/v3/repos/test-org/public-repo/hooks/32394 (events: [PULL_REQUEST, PUSH, REPOSITORY])
      Apr 30, 2020 12:42:10 AM FINE com.cloudbees.jenkins.GitHubWebHook$1 apply
      Calling registerHooks() for dse-team-apac/aburdajewicz/testOrg/private-repo
      Apr 30, 2020 12:42:10 AM INFO org.jenkinsci.plugins.github.webhook.WebhookManager$1 run
      GitHub webhooks activated for job dse-team-apac/aburdajewicz/testOrg/private-repo with [GitHubRepositoryName[host=github.example.com,username=test-org,repository=private-repo]] (events: [PULL_REQUEST, PUSH])
      Apr 30, 2020 12:42:10 AM FINE org.jenkinsci.plugins.github.webhook.WebhookManager$3 applyNullSafe
      Replaced hook https://github.example.com/api/v3/repos/test-org/private-repo/hooks/32393 (events: [PULL_REQUEST, PUSH, REPOSITORY])
      Apr 30, 2020 12:42:10 AM FINE org.jenkinsci.plugins.github.webhook.WebhookManager$3 applyNullSafe
      Created hook https://github.example.com/api/v3/repos/test-org/private-repo/hooks/32395 (events: [PULL_REQUEST, PUSH, REPOSITORY])
      

      The GitHub audit log is then showing a "hook.destroy" / "hook.create" for each repository. API rate seems to be wasted and those recreation seem unnecessary. The difference of events is odd too: [PULL_REQUEST, PUSH] vs [PULL_REQUEST, PUSH, REPOSITORY]. It seems related to how GitHub Plugin and GitHub Branch Source work together.

      h3 How to Reproduce

      • Configure a GitHub Server under *Manage Jenkins > Configure System > GitHub* and enabled "Manage Hooks"
      • Create a log recorder in *Manage Jenkins > System Logs* for org.jenkinsci.plugins.github.webhook.WebhookManager, com.cloudbees.jenkins.GitHubWebHook
      • Create an GitHub Organization item that match at least one repo
      • Run the Organization Scan a few times

      Check the log recorder and also the Audit log at $GITHUB_ORG_URL/settings/audit-log, You shell see that hooks are replaced on Organization Scan.

        Attachments

          Activity

          Hide
          allan_burdajewicz Allan BURDAJEWICZ added a comment -

          I can actually still see this when disabling the "Manage Webhooks" under Manage Jenkins > Configure System > GitHub. The creation / deletion of webhooks in that case is still triggered. But fails with credentials issues.

          Show
          allan_burdajewicz Allan BURDAJEWICZ added a comment - I can actually still see this when disabling the "Manage Webhooks" under Manage Jenkins > Configure System > GitHub . The creation / deletion of webhooks in that case is still triggered. But fails with credentials issues.
          Show
          olamy Olivier Lamy added a comment - pr  https://github.com/jenkinsci/github-plugin/pull/230  
          Hide
          lifeofguenter Gunter Grodotzki added a comment -

          similar to Allan BURDAJEWICZ - I am still seeing this issue even though I disabled webhook management

          Show
          lifeofguenter Gunter Grodotzki added a comment - similar to Allan BURDAJEWICZ - I am still seeing this issue even though I disabled webhook management
          Hide
          allan_burdajewicz Allan BURDAJEWICZ added a comment - - edited

          Gunter Grodotzki what version of the GitHub plugin are you running ? it supposed to be fixed in version 1.30.0.

          Show
          allan_burdajewicz Allan BURDAJEWICZ added a comment - - edited Gunter Grodotzki what version of the GitHub plugin are you running ? it supposed to be fixed in version 1.30.0.
          Hide
          lifeofguenter Gunter Grodotzki added a comment -

          I am on version 1.30.0

          Show
          lifeofguenter Gunter Grodotzki added a comment - I am on version 1.30.0

            People

            • Assignee:
              lanwen Kirill Merkushev
              Reporter:
              allan_burdajewicz Allan BURDAJEWICZ
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: