Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62866

Form changes: ATH errors for CasC plugin

    Details

    • Similar Issues:

      Description

      The following ATH errors for the plugin may be caused the tables-to-divs changes:

      • plugins.ConfigurationAsCodeTest.loadAndReload

        Attachments

          Activity

          Hide
          timja Tim Jacomb added a comment -

          Félix Queiruga Balado this is unrelated to tables and divs.

          Looks like it was the buttons rework and it's actually broken

          Non tables to divs:

          tables to divs:

          With tables to divs the message becomes visible again but half cut off

          Show
          timja Tim Jacomb added a comment - Félix Queiruga Balado this is unrelated to tables and divs. Looks like it was the buttons rework and it's actually broken Non tables to divs: tables to divs: With tables to divs the message becomes visible again but half cut off
          Hide
          timja Tim Jacomb added a comment -

          For the production code issue:
          https://github.com/jenkinsci/configuration-as-code-plugin/pull/1443

          ATH will probably still need a patch as it was passing even though broken on latest core (browser could still see the text I guess / it was in the DOM)

          Show
          timja Tim Jacomb added a comment - For the production code issue: https://github.com/jenkinsci/configuration-as-code-plugin/pull/1443 ATH will probably still need a patch as it was passing even though broken on latest core (browser could still see the text I guess / it was in the DOM)
          Show
          timja Tim Jacomb added a comment - and the ATH issue: https://github.com/jenkinsci/acceptance-test-harness/pull/598
          Hide
          fqueiruga Félix Queiruga Balado added a comment -

          Great find! Should we have a patch in place for the current ATH iteration while the tables-to-divs compat is not merged?

          Show
          fqueiruga Félix Queiruga Balado added a comment - Great find! Should we have a patch in place for the current ATH iteration while the tables-to-divs compat is not merged?
          Hide
          timja Tim Jacomb added a comment -

          so ath was actually passing on the current release...
          the functionality was broken, but selenium could still query for the text through xpath...

          I noticed as I was watching the test run, i.e. it looked broken on tables to divs, and then I tried a released core and it was completely broken for the user...

          re the ath patch I expect to get them all merged this week...

          Show
          timja Tim Jacomb added a comment - so ath was actually passing on the current release... the functionality was broken, but selenium could still query for the text through xpath... I noticed as I was watching the test run, i.e. it looked broken on tables to divs, and then I tried a released core and it was completely broken for the user... re the ath patch I expect to get them all merged this week...

            People

            • Assignee:
              timja Tim Jacomb
              Reporter:
              fqueiruga Félix Queiruga Balado
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: