Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-6412

Cannot reuse a clientspec on different machines - since changelist 28778

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The perforce plugin now sets dontRenameClient to false in the file PerforceSCM.java

      However in the this change now causes all clientspecs to have a hostname 'forced' on them because the following is never executed.

      if (dontRenameClient)

      { p4workspace.setHost(""); }

      Thus if the same workspace is used on multiple machines, the clientspec is not permitted to be used on machine except the one it was created on. I would suggest changing the code above to always remove the hostname from the client spec, or add back the flag 'dontReNameClient'.

      Note that there are other side effects - the the line stating that a shared workspace is being used isnt reported either.

        Attachments

          Activity

          Hide
          rpetti Rob Petti added a comment -

          Ah yes, dontRenameClient was replaced with a configurable slave name. I'll change this so it will always clear the host field, but I will note that sharing client specs between machines is a VERY bad idea since it can cause all sorts of synchronization issues.

          Show
          rpetti Rob Petti added a comment - Ah yes, dontRenameClient was replaced with a configurable slave name. I'll change this so it will always clear the host field, but I will note that sharing client specs between machines is a VERY bad idea since it can cause all sorts of synchronization issues.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : rpetti
          Path:
          trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java
          http://jenkins-ci.org/commit/30613
          Log:
          [FIXED JENKINS-6412] always clear the host field

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : rpetti Path: trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java http://jenkins-ci.org/commit/30613 Log: [FIXED JENKINS-6412] always clear the host field

            People

            • Assignee:
              rpetti Rob Petti
              Reporter:
              martinfr62 martinfr62
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: