Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-6560

Plugin should use project.getFullDisplayName() instead of project.getName()

    Details

    • Similar Issues:

      Description

      Seems like its only using the name of the matrix build/configuration when notifying:

      Starting build 226 for job jdk=1.6,label=ubuntu (previous build: STILL FAILING -- last SUCCESS #223 14 hr ago)
      

      Not very helpful for identifying which project this build is for...

      Stuff like this:

      final String message = "Build " + build.getProject().getName() +
      

      Should be:

      final String message = "Build " + build.getProject().getFullDisplayName() +
      

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : kutzi
            Path:
            trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/IMPublisher.java
            trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/bot/AbortCommand.java
            trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/bot/HealthCommand.java
            trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/bot/QueueCommand.java
            trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/bot/StatusCommand.java
            trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/bot/TestResultCommand.java
            trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/tools/BuildHelper.java
            trunk/hudson/plugins/instant-messaging/src/test/java/hudson/plugins/im/bot/HealthCommandTest.java
            http://jenkins-ci.org/commit/31543
            Log:
            [FIXED JENKINS-6560] use project.getFullDisplayName() instead of getName()

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : kutzi Path: trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/IMPublisher.java trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/bot/AbortCommand.java trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/bot/HealthCommand.java trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/bot/QueueCommand.java trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/bot/StatusCommand.java trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/bot/TestResultCommand.java trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/tools/BuildHelper.java trunk/hudson/plugins/instant-messaging/src/test/java/hudson/plugins/im/bot/HealthCommandTest.java http://jenkins-ci.org/commit/31543 Log: [FIXED JENKINS-6560] use project.getFullDisplayName() instead of getName()
            Hide
            user57 user57 added a comment -

            Can you release the instant-messaging plugin so I can use this?

            Show
            user57 user57 added a comment - Can you release the instant-messaging plugin so I can use this?
            Hide
            user57 user57 added a comment -

            Works much better now. Thx.

            Show
            user57 user57 added a comment - Works much better now. Thx.
            Hide
            habbie Peter van Dijk added a comment -

            A similar problem happens in 'currently building': I get "opencsw#2: unstable11s,opencsw (Elapsed time: 30 min, Estimated remaining time: 29 min)" where unstable11s,opencsw are matrix properties. The actual build name is missing.

            Using IRC 2.25 + instant-messaging 1.30.

            Can we reopen this ticket because the issue is similar?

            Show
            habbie Peter van Dijk added a comment - A similar problem happens in 'currently building': I get "opencsw#2: unstable11s,opencsw (Elapsed time: 30 min, Estimated remaining time: 29 min)" where unstable11s,opencsw are matrix properties. The actual build name is missing. Using IRC 2.25 + instant-messaging 1.30. Can we reopen this ticket because the issue is similar?
            Show
            habbie Peter van Dijk added a comment - Please reopen for !cb, see comment at https://issues.jenkins-ci.org/browse/JENKINS-6560?focusedCommentId=218649&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-218649
            Hide
            kutzi kutzi added a comment -

            Can you please exactly describe what you're seeing vs what would you expect? Ideally with steps how to reproduce it with a minimal matrix job.

            Sorry, I don't use any matrix jobs personally, so I'm not into the material.

            Show
            kutzi kutzi added a comment - Can you please exactly describe what you're seeing vs what would you expect? Ideally with steps how to reproduce it with a minimal matrix job. Sorry, I don't use any matrix jobs personally, so I'm not into the material.
            Hide
            danielbeck Daniel Beck added a comment -

            kutzi:

            1. Create a multi-configuration job 'foo'
            2. Add a user-defined matrix axis 'jdk' with values e.g. '1.5' and '1.6'
            3. Add a user-defined matrix axis 'label' with values e.g. 'redhat' and 'ubuntu'
            4. Configure IM plugin to print the output from the request

            It will show your project as:

            jdk=1.6,label=ubuntu

            Expected would be something like:

            foo/jdk=1.6,label=ubuntu

            (if using 'getFullName()' rather than 'getFullDisplayName()', I don't know what the latter looks like)

            This is also relevant for projects whose parent ItemGroup is not Jenkins.getInstance(), e.g. when using the Cloudbees Folder plugin.

            Show
            danielbeck Daniel Beck added a comment - kutzi: 1. Create a multi-configuration job 'foo' 2. Add a user-defined matrix axis 'jdk' with values e.g. '1.5' and '1.6' 3. Add a user-defined matrix axis 'label' with values e.g. 'redhat' and 'ubuntu' 4. Configure IM plugin to print the output from the request It will show your project as: jdk=1.6,label=ubuntu Expected would be something like: foo/jdk=1.6,label=ubuntu (if using 'getFullName()' rather than 'getFullDisplayName()', I don't know what the latter looks like) This is also relevant for projects whose parent ItemGroup is not Jenkins.getInstance(), e.g. when using the Cloudbees Folder plugin.
            Hide
            kutzi kutzi added a comment -

            Daniel, are you monitoring every single ticket in jira?

            Thanks for the instructions! I'll look into it.

            Show
            kutzi kutzi added a comment - Daniel, are you monitoring every single ticket in jira? Thanks for the instructions! I'll look into it.
            Hide
            habbie Peter van Dijk added a comment -

            (step 4 is not necessary for this issue)

            Show
            habbie Peter van Dijk added a comment - (step 4 is not necessary for this issue)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Christoph Kutzinski
            Path:
            src/main/java/hudson/plugins/im/bot/CurrentlyBuildingCommand.java
            http://jenkins-ci.org/commit/instant-messaging-plugin/4ca5e97cfdd01ab23e7301f66cfa3471f8a17d3e
            Log:
            Use FullDisplayName for 'cb' command, too, if available JENKINS-6560

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/plugins/im/bot/CurrentlyBuildingCommand.java http://jenkins-ci.org/commit/instant-messaging-plugin/4ca5e97cfdd01ab23e7301f66cfa3471f8a17d3e Log: Use FullDisplayName for 'cb' command, too, if available JENKINS-6560
            Hide
            kutzi kutzi added a comment -

            Should be fixed in version 1.32 of the instant-messaging plugin

            Show
            kutzi kutzi added a comment - Should be fixed in version 1.32 of the instant-messaging plugin

              People

              • Assignee:
                kutzi kutzi
                Reporter:
                user57 user57
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: