Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-6575

requiresWorkspaceForPolling needs to return false when dynamic slaves are used

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      requiresWorkspaceForPolling needs to be able to return false for certain builds which rely on dynamic slaves only.

      To do this I have selected the value when getSlaveClientNameFormat().equals("${basename}") returns true.

      Thus when a build uses a set of dynamic slaves, polling can be done on the master by 'reusing' the same workspace name for all builds, so that this workspace can also be used on the master and the p4 changes will work.

      Supplied patch enables this, and has been tested in a dynamic slave only environment, where no slave is available for polling to run on.

        Attachments

          Activity

          Hide
          rpetti Rob Petti added a comment -

          Looks pretty good, though I'm going to change the decision logic. It's not enough that you check that it equals "${basename}", you also need to check to see if it's static between slaves. For example, someone could specify "workspace_name" explicitly, or have some sort of prefix/suffix applied to the name, such as "someprefix-${basename}-somesuffix".

          Show
          rpetti Rob Petti added a comment - Looks pretty good, though I'm going to change the decision logic. It's not enough that you check that it equals "${basename}", you also need to check to see if it's static between slaves. For example, someone could specify "workspace_name" explicitly, or have some sort of prefix/suffix applied to the name, such as "someprefix-${basename}-somesuffix".
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : rpetti
          Path:
          trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java
          trunk/hudson/plugins/perforce/src/main/webapp/help/clientNameFormat.html
          http://jenkins-ci.org/commit/31209
          Log:
          [FIXED JENKINS-6575] applying patch provided by martinfr62

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : rpetti Path: trunk/hudson/plugins/perforce/src/main/java/hudson/plugins/perforce/PerforceSCM.java trunk/hudson/plugins/perforce/src/main/webapp/help/clientNameFormat.html http://jenkins-ci.org/commit/31209 Log: [FIXED JENKINS-6575] applying patch provided by martinfr62

            People

            • Assignee:
              rpetti Rob Petti
              Reporter:
              martinfr62 martinfr62
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: