Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7054

RetentionStrategy$Demand not respecting Mode.EXCLUSIVE

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: remoting
    • Labels:
      None
    • Environment:
      1.368-SNAPSHOT

      Description

      Queue._getBuildableItems looks at queued items and says they are buildable on a Computer if the task is not tied to a label or label matches the Computer. If the task is not tied to a label it does NOT check if the Computer is Mode.EXCLUSIVE (ie, "for tied jobs only").
      Thus, an on-demand slave may launch its connection when an untied job is in the queue, even though that slave cannot run the task.
      _getBuildableItems should either check the Mode, or maybe better use Node.canTake(task) to determine if the task can run on this Computer.

        Activity

        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in hudson
        User: : mindless
        Path:
        trunk/hudson/main/core/src/main/java/hudson/model/Queue.java
        trunk/www/changelog.html
        http://jenkins-ci.org/commit/33185
        Log:
        [FIXED JENKINS-7054] use Node.canTake(Task) in Queue._getBuildableItems so that
        Mode.EXCLUSIVE ("only for tied jobs") setting is respected.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/main/core/src/main/java/hudson/model/Queue.java trunk/www/changelog.html http://jenkins-ci.org/commit/33185 Log: [FIXED JENKINS-7054] use Node.canTake(Task) in Queue._getBuildableItems so that Mode.EXCLUSIVE ("only for tied jobs") setting is respected.

          People

          • Assignee:
            mindless Alan Harder
            Reporter:
            mindless Alan Harder
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: